fix: Automate worker + wasm resource detection#55
Merged
GordonSmith merged 1 commit intobytecodealliance:mainfrom Jun 15, 2025
Merged
fix: Automate worker + wasm resource detection#55GordonSmith merged 1 commit intobytecodealliance:mainfrom
GordonSmith merged 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy manual resource copy test and streamlines dependency declarations in package.json to support automated detection of worker and WASM resources.
- Delete old
build-resources.test.tsthat manually checked WASM files. - Remove explicit
@bytecodealliance/componentize-jsdependency from package.json.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/build-resources.test.ts | Remove deprecated manual WASM/worker copy tests |
| package.json | Drop hardcoded componentize-js dependency entry |
Comments suppressed due to low confidence (2)
tests/build-resources.test.ts:1
- Removing this entire test file eliminates verification for resource copying. Consider adding new tests to validate the automated detection logic for both worker and WASM resources.
/**
package.json:47
- Dropping the
componentize-jsdependency may break builds or runtime imports if any code still relies on it. Ensure all references to this package in the codebase are removed or handled by the new detection mechanism.
"@bytecodealliance/componentize-js": "0.18.2",
GordonSmith
force-pushed
the
TECH_DEBT_CLEANUP
branch
from
cd2d4fb to
dba788e
Compare
Signed-off-by Gordon Smith<GordonJSmith@gmail.com>
GordonSmith
force-pushed
the
TECH_DEBT_CLEANUP
branch
from
dba788e to
76197ef
Compare
Contributor
|
🎉 This change has been included in wit-idl-v0.3.6 🎉 The release is available on:
Your release-please bot 🚀🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by Gordon SmithGordonJSmith@gmail.com