Opt out of tokio's per-task budget in wasip2 noop polls - #14265
Merged
Conversation
This commit updates various calls of `noop_waker` and `poll_noop` throughout wasip2 to ensure they're all using `tokio::task::unconstrained` to specifically opt-out of Tokio's default task-budgeting mechanism. This is necessary to get some various tests I'm working on wasi-libc working on wasip2 because otherwise the test exhausts the task budget pretty quickly and then results in pretty surprising I/O behavior. One example is that a TCP socket ready for writing with `check-write` is subsequently not actually ready for writing because the task budget ran out. To the best of my ability to understand what I'm running into is the same as what's run into in bytecodealliance#14174. I'm not entirely sure though, but I'm going to conservatively say... Closes bytecodealliance#14174
pchickey
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates various calls of
noop_wakerandpoll_noopthroughout wasip2 to ensure they're all usingtokio::task::unconstrainedto specifically opt-out of Tokio's default task-budgeting mechanism. This is necessary to get some various tests I'm working on wasi-libc working on wasip2 because otherwise the test exhausts the task budget pretty quickly and then results in pretty surprising I/O behavior. One example is that a TCP socket ready for writing withcheck-writeis subsequently not actually ready for writing because the task budget ran out.To the best of my ability to understand what I'm running into is the same as what's run into in #14174. I'm not entirely sure though, but I'm going to conservatively say...
Closes #14174