fix: avoid map_from_entries error on empty array(unknown)#640
Open
zjuwangg wants to merge 1 commit into
Open
Conversation
For Presto, map_from_entries on array(unknown) previously marked all selected rows as errored, even rows whose array was empty. Empty arrays should produce empty maps without raising "map entry cannot be null". Only flag the error on rows whose array size is greater than zero.
Contributor
Author
|
cherry-pick from facebookincubator/velox@48cb6b1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Presto, map_from_entries on array(unknown) previously marked all selected rows as errored, even rows whose array was empty. Empty arrays should produce empty maps without raising "map entry cannot be null". Only flag the error on rows whose array size is greater than zero.
What problem does this PR solve?
Issue Number: close #xxx
Type of Change
Description
Describe your changes in detail.
For complex logic, explain the "Why" and "How".
Performance Impact
[ ✅] No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
[ ✅] No
Yes (Description: ...)
Click to view Breaking Changes