Skip to content

fix(minimap): use explicit return false in filter callbacks#1135

Open
hobostay wants to merge 1 commit into
bytedance:mainfrom
hobostay:fix/minimap-filter-return-statements
Open

fix(minimap): use explicit return false in filter callbacks#1135
hobostay wants to merge 1 commit into
bytedance:mainfrom
hobostay:fix/minimap-filter-return-statements

Conversation

@hobostay

Copy link
Copy Markdown

Fix return; statements in Array.filter() callbacks in minimap transformVisibles getter. Changed to explicit return false for correct semantics.

Changes

  • Line 260: return; -> return false
  • Line 267: return; -> return false

Test plan

  • Verify minimap correctly filters root and non-first-level nodes
  • Run rush test

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Test User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@hobostay hobostay force-pushed the fix/minimap-filter-return-statements branch from 88cd703 to 769c692 Compare May 22, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants