Fix(query): default-select sole molecular profile (fixes #11569)#5518
Draft
Pragati5-DEBUG wants to merge 4 commits into
Draft
Fix(query): default-select sole molecular profile (fixes #11569)#5518Pragati5-DEBUG wants to merge 4 commits into
Pragati5-DEBUG wants to merge 4 commits into
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
added 4 commits
June 29, 2026 23:07
- Add getSingleSelectableProfileSuffixIfUnique: one suffix across selectable profiles - QueryStore: apply only when selectedProfileIdSet is still empty (mixed cohort safe) - getDefaultMolecularProfiles: fallback when no mutation/CNA/SV default but one profile - StudyView onSubmitQuery: pass profileFilter when only one profile exists Incorporates feedback from PR cBioPortal#5215 (store-level) and cBioPortal#5462 (no override when defaults exist).
Keep #11569 fallback active whenever selected profile set is empty, even if profileFilterSet is initialized but has no entries. This addresses single-profile studies where the map exists yet nothing is selected.
Clear profileFilterSetFromUrl on each setParamsFromUrl call and compact split values. This prevents stale URL filter state from suppressing #11569 single-profile fallback on subsequent query loads.
Select the default profile during molecular profile load using computed store getters (as in cBioPortal#5215) so the checkbox state is reflected immediately. Keep URL-driven profile selections authoritative by skipping auto-select when profile filters/ids are present.
onursumer
force-pushed
the
fix/11569-single-profile-default
branch
from
6154481 to
d399125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11569
Summary
Follow-up fixes in this PR
profileFilterSetFromUrlon each URL parseDemo
Verified on deploy preview: https://deploy-preview-5518.preview.cbioportal.org
Test plan
Multi-profile / mixed-cohort regression check (deploy-preview-5518): query behavior remains normal; no unintended forced single-profile selection.
URL profile override
https://deploy-preview-5518.preview.cbioportal.org/results/oncoprint?cancer_study_list=ovary_geomx_gray_foundation_2024&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mrna_seq_read_counts_Zscores&case_set_id=ovary_geomx_gray_foundation_2024_all&gene_list=SOX9%2520RAN%2520TNK2%2520EP300%2520PXN%2520NCOA2%2520AR%2520NRIP1%2520NCOR1%2520NCOR2&geneset_list=%20&tab_index=tab_visualize&Action=Submit