Skip to content

feat(frontend): add opt-in HTTP API toggle with configurable port and…#67

Open
HoaMi wants to merge 1 commit into
cadence-workflow:mainfrom
HoaMi:feat/frontend-http-api-toggle
Open

feat(frontend): add opt-in HTTP API toggle with configurable port and…#67
HoaMi wants to merge 1 commit into
cadence-workflow:mainfrom
HoaMi:feat/frontend-http-api-toggle

Conversation

@HoaMi

@HoaMi HoaMi commented Apr 17, 2026

Copy link
Copy Markdown

Summary

Adds an opt-in HTTP API on the Cadence frontend, disabled by default, as described in https://cadenceworkflow.io/docs/concepts/http-api.

New values under frontend.httpApi:

  • enabled (default false)
  • port (default 8800)
  • procedures (default [], list of <proto-pkg>.<Service>::<Method> entries to expose)

When enabled, the chart:

  • renders an http: { port, procedures } block under services.frontend.rpc in the server config,
  • exposes an http port on the frontend Service,
  • declares the matching containerPort on the frontend Deployment.

When disabled (default), no HTTP port or config section is produced, so existing deployments are unchanged.

Docs regenerated with helm-docs.

Test plan

  • helm lint charts/cadence passes
  • helm template with defaults: no http: block, no 8800 port anywhere
  • helm template with frontend.httpApi.enabled=true and a procedures list: http block rendered under services.frontend.rpc, http port on Service and Deployment
  • Deploy to a cluster, curl an exposed procedure against the frontend http port

Comment thread charts/cadence/templates/server-configmap.yaml
@HoaMi HoaMi force-pushed the feat/frontend-http-api-toggle branch from 0308123 to aff9714 Compare April 17, 2026 15:10
… procedures

Signed-off-by: HoaMi <github@hoami.org>
@HoaMi HoaMi force-pushed the feat/frontend-http-api-toggle branch from aff9714 to 7130b10 Compare April 17, 2026 15:12
@gitar-bot

gitar-bot Bot commented Apr 17, 2026

Copy link
Copy Markdown
Code Review ✅ Approved 1 resolved / 1 findings

Adds an opt-in HTTP API toggle with configurable settings and fixes the empty procedures list rendering, ensuring it returns an empty array instead of null.

✅ 1 resolved
Edge Case: Empty procedures list renders as null instead of empty array

📄 charts/cadence/templates/server-configmap.yaml:510-513
When httpApi.enabled=true but procedures is left as the default empty list [], the range loop produces no items, so the rendered YAML becomes:

http:
  port: 8800
  procedures:

YAML parses a bare procedures: key as null, not as an empty list []. Depending on how the Cadence server deserializes this, it may panic on a nil slice or reject the config. This is the most likely misconfiguration since the default is procedures: [].

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants