Skip to content
This repository was archived by the owner on Jun 17, 2026. It is now read-only.

Support multiple packages in one repository.#38

Open
matthewhammer wants to merge 7 commits into
caffeinelabs:mainfrom
matthewhammer:multi-package-repo
Open

Support multiple packages in one repository.#38
matthewhammer wants to merge 7 commits into
caffeinelabs:mainfrom
matthewhammer:multi-package-repo

Conversation

@matthewhammer

Copy link
Copy Markdown

#37

@matthewhammer matthewhammer marked this pull request as draft November 9, 2021 18:54
@matthewhammer

Copy link
Copy Markdown
Author

This PR is still a draft, but it may be ready enough for initial feedback from @kritzcreek, for an initial sanity check. Going to change to "ready for review", even though there is probably more to do before reviewing fully.

@matthewhammer matthewhammer marked this pull request as ready for review November 9, 2021 19:52
@kritzcreek

Copy link
Copy Markdown
Contributor

Hey, I agree this is a desirable feature. I'm a bit worried about breaking all the package-sets we've put out there so far. Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Just a suggestion, if you think it's better to rip off the bandaid, I'm happy to approve.

@matthewhammer

Copy link
Copy Markdown
Author

Maybe we could make the parameter non-optional, but continue to try and parse the old format for a while? While emitting a warning that we defaulted the path configuration to src for all the packages that were missing it?

Okay, I like that idea, and concurrently I had begun to sour on the optional-ness of path, and wanted to also make it mandatory, where people would write "src" to get the current behavior. This evolution path seems natural and good to me! Thanks for taking a look!

@q-uint

q-uint commented Jan 15, 2022

Copy link
Copy Markdown

Hi @matthewhammer, any plans to pick this up again? Do you need a hand?

@q-uint q-uint mentioned this pull request Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants