GH4945: Add GitHub Actions NuGetLogin for OIDC - #4946
Merged
Conversation
Add `GitHubActionsCommands.NuGetLogin` to exchange a GitHub Actions OIDC identity token for a short-lived NuGet.org API key, enabling trusted publishing from Cake scripts without storing long-lived credentials. - Add `GitHubNuGetLoginSettings` with defaults for NuGet token service URL and OIDC audience - Add internal `GitHubNuGetLoginService` to request the OIDC JWT from GitHub and exchange it with the NuGet token service - Add source-generated JSON models and serialization context for OIDC and token exchange payloads - Wire `NuGetLogin` overloads on `GitHubActionsCommands` (username-only and settings-based) - Add unit tests with a fake `HttpMessageHandler` fixture covering success, validation, and HTTP failure paths - Add optional GitHub Actions integration test gated on `CAKE_INTEGRATIONTEST_NUGET_USERNAME` - Integration test Validate NuGetLogin API key with nuget.org verify-scope protocol Extend the GitHub Actions NuGetLogin integration test to confirm the OIDC-exchanged API key is accepted by nuget.org using the verify-scope create-verification-key and verifykey APIs. - fixes cake-build#4945
Member
|
@devlead this is a great addition, thanks for getting this added! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
GitHubActionsCommands.NuGetLoginto exchange a GitHub Actions OIDC identity token for a short-lived NuGet.org API key, enabling trusted publishing from Cake scripts without storing long-lived credentials.GitHubNuGetLoginSettingswith defaults for NuGet token service URL and OIDC audienceGitHubNuGetLoginServiceto request the OIDC JWT from GitHub and exchange it with the NuGet token serviceNuGetLoginoverloads onGitHubActionsCommands(username-only and settings-based)HttpMessageHandlerfixture covering success, validation, and HTTP failure pathsCAKE_INTEGRATIONTEST_NUGET_USERNAME