Adds encoder type with a circle (50% border radius) drawing style - #64
patricksurry wants to merge 3 commits into
Conversation
|
a simple idea to show rotation actions might be to add optional i could do a quick mock if that sounds interesting. |
|
Thanks again, I can probably handle the rebase once the other one is in. I'd be curious to see how you envision how it would look like, especially how to fit the cw/ccw legends in with the tap as well! I haven't thought about a good way myself but I never seriously tried. In general, I am on the fence on how best to support encoders in the keymap spec. Your proposed approach is one way, where encoder is just another key in the layer but can have additional properties. It doesn't work well if the encoder doesn't have a push button, like EC12 encoders. But I suppose most firmware will assume compatibility with both, so we might be able to assume it will always have a corresponding position on the layer. Another approach would be to assign them in a separate |
afbdb42 to
140ca43
Compare

This adds a second commit on top of the qmk_info PR which adds the circled encoder drawing style.
There'd be more needed to display encoder twist actions but seems nice/easy to at least draw a circular representation.
It wasn't obvious how to make a completely independent PR since the example extends the previous one.
But if you prefer to separate in a different way, or reject the earlier PR, lmk.