Skip to content

Refactor: Class-based views - Help page - #3052

Closed
machikoyasuda wants to merge 5 commits into
mainfrom
refactor/3000-cbv--help
Closed

Refactor: Class-based views - Help page#3052
machikoyasuda wants to merge 5 commits into
mainfrom
refactor/3000-cbv--help

Conversation

@machikoyasuda

@machikoyasuda machikoyasuda commented Jul 29, 2025

Copy link
Copy Markdown
Member

closes #3000

What this PR does

  • Update views, urls, use pageview decorator
  • Update test
  • Update get_context_data

How to test

  • Check help page when agency is None
  • Check help page when agency is CST: There should be questions and answers about CST-specific flows
  • Check in the logs that the middleware analytics event function is getting hit

@machikoyasuda machikoyasuda self-assigned this Jul 29, 2025
@machikoyasuda
machikoyasuda requested a review from a team as a code owner July 29, 2025 23:05
@github-actions github-actions Bot added the back-end Django views, sessions, middleware, models, migrations etc. label Jul 29, 2025
@machikoyasuda
machikoyasuda marked this pull request as draft July 29, 2025 23:07
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  urls.py
  views.py
  benefits/eligibility
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@machikoyasuda

Copy link
Copy Markdown
Member Author

Closing this for the time being b/c I want to do a future PR with all the Help copy context as well

@angela-tran
angela-tran deleted the refactor/3000-cbv--help branch November 7, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back-end Django views, sessions, middleware, models, migrations etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Class-based views: Core help

1 participant