Skip to content

chore(pre-commit): autoupdate hooks - #3216

Merged
jgravois merged 1 commit into
mainfrom
pre-commit-ci-update-config
Feb 26, 2026
Merged

chore(pre-commit): autoupdate hooks#3216
jgravois merged 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  mixins.py
  session.py
  benefits/core/admin
  enrollment.py
  benefits/core/models
  enrollment.py
  transit.py
  benefits/eligibility
  views.py
  benefits/enrollment
  enrollment.py
  benefits/enrollment_littlepay
  models.py
  benefits/enrollment_switchio
  models.py
  views.py
Project Total  

This report was generated by python-coverage-comment-action

@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 6a6a9cb to 9103969 Compare October 13, 2025 17:59
@thekaveman

Copy link
Copy Markdown
Member

This is annoying. It undid what @jgravois fixed in #3225. Is there a way to tell pre-commit-ci we don't want updates for certain hooks but we're OK with getting updates for others?

@thekaveman thekaveman added the dependencies [auto] Pull requests that update 3rd party software libraries and requirements label Oct 21, 2025
@jgravois

Copy link
Copy Markdown
Member

Is there a way to tell pre-commit-ci we don't want updates for certain hooks but we're OK with getting updates for others?

not deep research by any means, but it doesn't look like it... pre-commit/pre-commit#1959

@thekaveman

thekaveman commented Oct 21, 2025

Copy link
Copy Markdown
Member

Is there a way to tell pre-commit-ci we don't want updates for certain hooks but we're OK with getting updates for others?

not deep research by any means, but it doesn't look like it... pre-commit/pre-commit#1959

Their docs seem to indicate this is now supported 🤔 https://pre-commit.ci/#configuration-skip

(And note this is specifically the pre-commit CI service, which builds on top of pre-commit the tool)

@thekaveman thekaveman self-assigned this Oct 21, 2025
@Scotchester

Copy link
Copy Markdown
Member

Is there a way to tell pre-commit-ci we don't want updates for certain hooks but we're OK with getting updates for others?

not deep research by any means, but it doesn't look like it... pre-commit/pre-commit#1959

Their docs seem to indicate this is now supported 🤔 https://pre-commit.ci/#configuration-skip

(And note this is specifically the pre-commit CI service, which builds on top of pre-commit the tool)

I believe that will actually skip running a hook in CI, not skip updating it, per this explanation in the last line of that section:

this is equivalent to running SKIP=pylint pre-commit ...

@thekaveman

Copy link
Copy Markdown
Member

Is there a way to tell pre-commit-ci we don't want updates for certain hooks but we're OK with getting updates for others?

not deep research by any means, but it doesn't look like it... pre-commit/pre-commit#1959

Their docs seem to indicate this is now supported 🤔 https://pre-commit.ci/#configuration-skip
(And note this is specifically the pre-commit CI service, which builds on top of pre-commit the tool)

I believe that will actually skip running a hook in CI, not skip updating it, per this explanation in the last line of that section:

this is equivalent to running SKIP=pylint pre-commit ...

Ah, damn, you are right

@jgravois

Copy link
Copy Markdown
Member

if push comes to shove, we could also figure out how to get the prettier VSCode extension to load the latest and greatest (or find another solution for auto-formatting CSS because i think those are the only files prettier is even in charge of...

@Scotchester

Copy link
Copy Markdown
Member

if push comes to shove, we could also figure out how to get the prettier VSCode extension to load the latest and greatest

Yeah, that's probably the better path to take.

Per the prettier-vscode README, since we're not specifying it, it's falling back to the bundled version, which is inexplicably set to ^2.8.8 still.

The unfortunate thing is that we currently have the glorious situation of not needing any Node dependencies, and this would be the first. Node module is the only officially supported installation, though there might be someone who's created a Python adapter or something.

or find another solution for auto-formatting CSS because i think those are the only files prettier is even in charge of

Or that could be good, too. (We do also use it for JS, though.)


Sidenote: I don't love that pre-commit/mirrors-prettier is pushing us toward an an alpha version. I hope that might be configurable, at least…

@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 291aeb5 to cf15adf Compare November 17, 2025 17:55
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8744614 to a52a6cf Compare November 24, 2025 18:03
@angela-tran

Copy link
Copy Markdown
Member

Gonna put this in Draft until we figure out what we want to do here

@angela-tran
angela-tran marked this pull request as draft December 4, 2025 20:55
@jgravois

jgravois commented Dec 4, 2025

Copy link
Copy Markdown
Member

just to leave a breadcrumb...

i noticed in cal-itp/calitp.org#537 that migrating calitp.org from esbenp.prettier-vscode to prettier.prettier-vscode will get us to prettier@3x all on its own.

that might be enough to unblock this PR all on its own 😇

@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 507366f to 5afa8d6 Compare December 8, 2025 18:03
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 830f93d to b593cdd Compare January 19, 2026 18:08
@pre-commit-ci
pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 23b7314 to d5f8dc9 Compare February 23, 2026 18:06
@thekaveman

Copy link
Copy Markdown
Member

@jgravois want to rebase this one on your latest changes from #3520 so we can finally start getting pre-commit updates again?? 🙏

@thekaveman thekaveman assigned jgravois and unassigned thekaveman Feb 25, 2026
@jgravois

Copy link
Copy Markdown
Member

@jgravois want to rebase this one

you got it. 🤙 i had forgotten all about this 😂

@jgravois
jgravois force-pushed the pre-commit-ci-update-config branch from c682f9c to e8aa62b Compare February 25, 2026 20:18
@jgravois

Copy link
Copy Markdown
Member

done and done. i'm particularly excited about this 👇

https://github.com/psf/black-pre-commit-mirror
Using this repository in your pre-commit config makes Black twice as fast.

@jgravois
jgravois marked this pull request as ready for review February 25, 2026 20:20

@jgravois jgravois left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but i've had my hand in the cookie jar.

i'll wait a bit before merging in case anyone else wants to take a look themselves.

@thekaveman thekaveman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until #3509 is merged, so we can rebase on that and then re-apply the prettier cleanups.

updates:
- [github.com/compilerla/conventional-pre-commit: v4.2.0 → v4.4.0](compilerla/conventional-pre-commit@v4.2.0...v4.4.0)
- https://github.com/psf/blackhttps://github.com/psf/black-pre-commit-mirror
- [github.com/psf/black-pre-commit-mirror: 25.9.0 → 26.1.0](psf/black-pre-commit-mirror@25.9.0...26.1.0)
- [github.com/pycqa/bandit: 1.8.6 → 1.9.3](PyCQA/bandit@1.8.6...1.9.3)
- [github.com/pycqa/isort: 7.0.0 → 8.0.0](PyCQA/isort@7.0.0...8.0.0)
- [github.com/pre-commit/mirrors-prettier: v2.7.1 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v2.7.1...v4.0.0-alpha.8)
@jgravois
jgravois force-pushed the pre-commit-ci-update-config branch from e8aa62b to 46654f0 Compare February 26, 2026 14:48
@jgravois
jgravois dismissed thekaveman’s stale review February 26, 2026 14:50

#3509 is now merged and this branch has been rebased on top of main.

@jgravois
jgravois requested a review from a team February 26, 2026 14:51
@jgravois
jgravois merged commit e454ac6 into main Feb 26, 2026
16 checks passed
@jgravois
jgravois deleted the pre-commit-ci-update-config branch February 26, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies [auto] Pull requests that update 3rd party software libraries and requirements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants