chore(pre-commit): autoupdate hooks - #3216
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
6a6a9cb to
9103969
Compare
not deep research by any means, but it doesn't look like it... pre-commit/pre-commit#1959 |
Their docs seem to indicate this is now supported 🤔 https://pre-commit.ci/#configuration-skip (And note this is specifically the |
I believe that will actually skip running a hook in CI, not skip updating it, per this explanation in the last line of that section:
|
Ah, damn, you are right |
|
if push comes to shove, we could also figure out how to get the prettier VSCode extension to load the latest and greatest (or find another solution for auto-formatting CSS because i think those are the only files prettier is even in charge of... |
Yeah, that's probably the better path to take. Per the prettier-vscode README, since we're not specifying it, it's falling back to the bundled version, which is inexplicably set to ^2.8.8 still. The unfortunate thing is that we currently have the glorious situation of not needing any Node dependencies, and this would be the first. Node module is the only officially supported installation, though there might be someone who's created a Python adapter or something.
Or that could be good, too. (We do also use it for JS, though.) Sidenote: I don't love that pre-commit/mirrors-prettier is pushing us toward an an alpha version. I hope that might be configurable, at least… |
291aeb5 to
cf15adf
Compare
8744614 to
a52a6cf
Compare
|
Gonna put this in Draft until we figure out what we want to do here |
|
just to leave a breadcrumb... i noticed in cal-itp/calitp.org#537 that migrating calitp.org from that might be enough to unblock this PR all on its own 😇 |
507366f to
5afa8d6
Compare
830f93d to
b593cdd
Compare
23b7314 to
d5f8dc9
Compare
you got it. 🤙 i had forgotten all about this 😂 |
c682f9c to
e8aa62b
Compare
|
done and done. i'm particularly excited about this 👇
|
jgravois
left a comment
There was a problem hiding this comment.
lgtm but i've had my hand in the cookie jar.
i'll wait a bit before merging in case anyone else wants to take a look themselves.
thekaveman
left a comment
There was a problem hiding this comment.
Let's wait until #3509 is merged, so we can rebase on that and then re-apply the prettier cleanups.
updates: - [github.com/compilerla/conventional-pre-commit: v4.2.0 → v4.4.0](compilerla/conventional-pre-commit@v4.2.0...v4.4.0) - https://github.com/psf/black → https://github.com/psf/black-pre-commit-mirror - [github.com/psf/black-pre-commit-mirror: 25.9.0 → 26.1.0](psf/black-pre-commit-mirror@25.9.0...26.1.0) - [github.com/pycqa/bandit: 1.8.6 → 1.9.3](PyCQA/bandit@1.8.6...1.9.3) - [github.com/pycqa/isort: 7.0.0 → 8.0.0](PyCQA/isort@7.0.0...8.0.0) - [github.com/pre-commit/mirrors-prettier: v2.7.1 → v4.0.0-alpha.8](pre-commit/mirrors-prettier@v2.7.1...v4.0.0-alpha.8)
e8aa62b to
46654f0
Compare
#3509 is now merged and this branch has been rebased on top of main.
updates:
github.com/pre-commit/mirrors-prettier: v2.7.1 → v4.0.0-alpha.8