Feat: add initial Roseville configuration - #3448
Merged
Merged
Conversation
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
thekaveman
force-pushed
the
feat/roseville
branch
from
January 27, 2026 22:33
4be75eb to
f8e6e6a
Compare
thekaveman
marked this pull request as ready for review
January 28, 2026 00:25
6 tasks
thekaveman
force-pushed
the
feat/roseville
branch
from
January 28, 2026 01:28
f8e6e6a to
6393a79
Compare
thekaveman
force-pushed
the
feat/roseville
branch
from
January 28, 2026 01:30
6393a79 to
21e4513
Compare
thekaveman
enabled auto-merge
January 28, 2026 02:06
Scotchester
approved these changes
Jan 28, 2026
Scotchester
left a comment
Member
There was a problem hiding this comment.
Couple notes for the future on translations, but this works as expected 👍
|
|
||
| msgid "Get your reduced fare on Roseville public transit when you tap to ride" | ||
| msgstr "" | ||
| "Obtenga una tarifa reducida en el transporte público Roseville cuando toque " |
Member
There was a problem hiding this comment.
Was this included accidentally, or is it a better translation than what we used before?
Suggested change
| "Obtenga una tarifa reducida en el transporte público Roseville cuando toque " | |
| "Obtenga una tarifa reducida en transporte público Roseville cuando toque " |
Comment on lines
+985
to
+988
| msgstr "" | ||
| "Cal-ITP no almacena su información. Todos los beneficios de tránsito de " | ||
| "Roseville reducen las tarifas en un 50%% para el servicio de autobús en " | ||
| "rutas fijas." |
Member
There was a problem hiding this comment.
Seeing this makes me realize we've translated this one in several different ways, too. With and without the "fixed routes" bit, and once without mentioning the percentage (SBMTD).
Not something to worry about here, probably, just something to remember when we get these translations into the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3171
I've confirmed the Littlepay configuration for Roseville in both QA and Prod.
This PR adds the agency slug and agency-specific copy for Roseville.