Conversation
|
Preview url: https://benefits-3547--cal-itp-previews.netlify.app |
a2e8bcd to
27eb88c
Compare
There was a problem hiding this comment.
i was surprised that an injected partial like this stops converting /secrets.md to /secrets automatically.
| - Choose the new `TransitAgency`. | ||
| - Retrieve Audience and Client ID values for the **production** config from shared LastPass note. | ||
| - Client Secret Name: `${agency_slug}-payment-processor-client-secret` | ||
| --8<-- "./inc/create-secret.md" |
There was a problem hiding this comment.
i was also surprised to find that i couldn't just place the partial in the previous /guides/inc directory and reference it like this 👇
--8<-- "../inc/create-secret.md"
There was a problem hiding this comment.
As in, the partial/include is always relative to the top-level of the docs dir, regardless of where it is being used?
There was a problem hiding this comment.
i've been thinking of it in terms of the --8<-- specifically possibly not being able to back out (or escape) the parent directory of the file currently being read.
it seemed harmless enough to scope the /inc where it ended up since no other guides reference it and i was clueless regarding how to debug the error, so i readily admit that i gave up trying to solve the riddle quite quickly.
There was a problem hiding this comment.
the hardest part of implementing this was figuring out how to dig up the v2 doc for this renamed plugin. 😂
https://github.com/lukasgeiter/mkdocs-awesome-nav/tree/v2
|
i believe i addressed all @thekaveman's good feedback in |
lalver1
left a comment
There was a problem hiding this comment.
It's looking real nice @jgravois! I like how the guide flows, the tabbed sections work well and splitting out the add, prod validation, prod, and post-launch sections to individual pages was a great idea! I only have a few minor comments/typo sort of things below.
| - Transit provider uses their Littlepay merchant ID to create a customer group in the Littlepay QA environment for each type of eligibility (e.g. older adult). | ||
| - _Typically performed by transit provider's Account Manager_ | ||
| - For each group that was created, a group ID will be returned and should be set as the `group_id` on a new `LittlepayGroup`. | ||
| - The new `LittlepayGroup` is then associated with an enrollment flow and transit provider using the dropdowns. (See [Configuration data](../tutorials/load-sample-data.md) for more on loading the database.) |
There was a problem hiding this comment.
🤔 looks like something is broken in the Configuration data link.
|
|
||
| Next steps: | ||
|
|
||
| - [Configure for production validation](./b-configure-production-validation.md) |
There was a problem hiding this comment.
Similarly, looks like something is broken in the Configure for production validation link.
| Next steps: | ||
|
|
||
| - [Configure for production validation](./b-configure-production-validation.md) | ||
| - [Configure for production](./c-configure-production.md) |
There was a problem hiding this comment.
Similarly, looks like something is broken in the Configure for production link.
| - _Typically performed by transit provider's Account Manager_ | ||
| - Once this is complete, verify that the setup is correct by using the [littlepay CLI](https://github.com/cal-itp/littlepay). Example: | ||
| 1. Transit provider staff creates the discount product and associated customer groups in production Littlepay. | ||
| 1. Transit provider provides group names and ids to Cal-ITPstaff takes a screenshot of the discount product in the Merchant Portal, making sure the browser URL is visible, and sends that to Cal-ITP. |
There was a problem hiding this comment.
Hmm, looks like something weird happened to this paragraph. I think we can remove the reference to taking a screenshot (I believe Kegan also mentioned this) and we could add something along the lines of "names and IDs of the groups that are relevant to the Benefits application". Because I feel like sometimes there's been a misunderstanding about which discounts Benefits actually supports. This way we don't get groups for youth or student discounts, for example.
| - This will be set back to QA after final production configuration is complete. | ||
| - Set Environment to **Production** for production validation. | ||
| - This will be set back to **Testing** after final production configuration is complete. | ||
| - Choose the new `TransitAgency`. |
There was a problem hiding this comment.
Would we need to update this from "Choose" to something like "Enter the slug of the new TransitAgency"? I think this is how the admin UI looks like at the moment.
There was a problem hiding this comment.
good catch. there is definitely a dropdown, but this relationship is actually set from TransitAgency now. 🙃
i went with:
return to the
TransitAgencyand associate the newLittlepayConfigas its 'Transit processor config'.
| 1. Cal-ITP associates the group with the discount product [created previously during production validation](#configuration-for-production-validation). | ||
| - Once this is complete, verify that the setup is correct by using the [littlepay CLI](https://github.com/cal-itp/littlepay). | ||
| 1. Transit agency creates a customer group **for production use** in production Littlepay. | ||
| 1. Transit agency associates the group with the discount product [created previously during production validation](#configuration-for-production-validation). |
There was a problem hiding this comment.
Something about this link seems like it's not taking me to the right place 🤔.
| 1. Transit agency creates a customer group **for production use** in production Littlepay. | ||
| 1. Transit agency associates the group with the discount product [created previously during production validation](#configuration-for-production-validation). | ||
| - Once this is complete, Cal-ITP verifies that the setup is correct by using the [littlepay CLI](https://github.com/cal-itp/littlepay). | ||
| 1. Cal-ITP creates a new `LittlepayGroup` in the Benefits prod environment: |
There was a problem hiding this comment.
Are we missing the "Cal-ITP creates a new TransitAgency in the Admin" step just before this one?
|
|
||
| === "Switchio" | ||
|
|
||
| 1. Cal-ITP creates a new `SwitchioConfig` in the Benefits production environment: |
There was a problem hiding this comment.
Are we missing a "Cal-ITP creates a new TransitAgency in the Admin" step just before this one?
There was a problem hiding this comment.
Small typo, we have test instead of production
There was a problem hiding this comment.
This link wasn't working for me 🤔
| 1. Cal-ITP creates a new `LittlepayConfig` in the Benefits test environment: | ||
| - Set Environment to **Production** for production validation. | ||
| - This will be set back to **Testing** after final production configuration is complete. | ||
| - return to the `TransitAgency` and associate the new `LittlepayConfig` as its 'Transit processor config'. |
There was a problem hiding this comment.
Sorry, very minor comment, maybe we can capitalize "Return" here to keep the same formatting as the other bullet points.
|
thank you @lalver1 et. al. 🌈 i'll go ahead and merge but if anyone else has any constructive criticism related to these updated guides, i'm genuinely interested in hearing it. |
thekaveman
left a comment
There was a problem hiding this comment.
This is looking really good. I like the separated pages, tabbed sections, etc.
Just a few more content comments and questions.
|
I didn't do a thorough review since Luis and Kegan had it covered, but this looks great at a glance. Awesome work, John! |
|
i guarantee there's still room for improvement. we can keep iterating as we onboard new agencies (and further simplify the steps!) 😈 |
closes #3539
i don't have a better recommendation for testing this than opening the new pages and the old guide side-by-side.
https://docs.calitp.org/benefits/guides/onboard-transit-provider/
i think the reorganization is an improvement, but it certainly makes it such that you can't pick up on the line item changes in the existing steps in the diff.