docs: Point Django docs links to stable version - #3573
Merged
Conversation
Contributor
|
Preview url: https://benefits-3573--cal-itp-previews.netlify.app |
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jgravois
previously approved these changes
Mar 11, 2026
jgravois
left a comment
Member
There was a problem hiding this comment.
if there's anywhere we can afford to be loose about versions, its here IMO. 🤗
thekaveman
previously approved these changes
Mar 11, 2026
Scotchester
force-pushed
the
docs/django-stable-links
branch
from
March 11, 2026 19:21
c8a281b to
ce9921c
Compare
Member
Author
|
Thought I'd double-check before merging and found a few I missed, which I amended to the original commit. I also hadn't looked at code comments before, so I've updated those in a second commit. One more review, please? |
thekaveman
requested changes
Mar 11, 2026
thekaveman
left a comment
Member
There was a problem hiding this comment.
There's one more ref I found:
Line 30 in ce9921c
Member
Author
Gah! Forgot to save (and thus commit) that one. Thanks. |
Scotchester
force-pushed
the
docs/django-stable-links
branch
from
March 11, 2026 19:33
ce9921c to
d61b8b4
Compare
Member
Author
|
Amended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose that when we link to the Django docs in our own docs, we link to the Stable version. Yes, technically we are behind that currently, but in general we move fairly quickly to update Django, and I'm not sure it's worth the maintenance burden of updating these URLs every time we update.
If others disagree, though, that's OK!