Skip to content

docs: Point Django docs links to stable version - #3573

Merged
Scotchester merged 2 commits into
mainfrom
docs/django-stable-links
Mar 11, 2026
Merged

docs: Point Django docs links to stable version#3573
Scotchester merged 2 commits into
mainfrom
docs/django-stable-links

Conversation

@Scotchester

Copy link
Copy Markdown
Member

I propose that when we link to the Django docs in our own docs, we link to the Stable version. Yes, technically we are behind that currently, but in general we move fairly quickly to update Django, and I'm not sure it's worth the maintenance burden of updating these URLs every time we update.

If others disagree, though, that's OK!

@Scotchester
Scotchester requested a review from a team as a code owner March 11, 2026 13:37
@github-actions github-actions Bot added the documentation [auto] Improvements or additions to documentation label Mar 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits
  secrets.py
  settings.py
  urls.py
  wsgi.py 10
  benefits/locale/en
  formats.py
  benefits/locale/es
  formats.py
Project Total  

This report was generated by python-coverage-comment-action

jgravois
jgravois previously approved these changes Mar 11, 2026

@jgravois jgravois left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there's anywhere we can afford to be loose about versions, its here IMO. 🤗

thekaveman
thekaveman previously approved these changes Mar 11, 2026
@Scotchester
Scotchester dismissed stale reviews from thekaveman and jgravois via ce9921c March 11, 2026 19:21
@Scotchester
Scotchester force-pushed the docs/django-stable-links branch from c8a281b to ce9921c Compare March 11, 2026 19:21
@Scotchester

Copy link
Copy Markdown
Member Author

Thought I'd double-check before merging and found a few I missed, which I amended to the original commit. I also hadn't looked at code comments before, so I've updated those in a second commit.

One more review, please?

@thekaveman thekaveman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more ref I found:

https://docs.djangoproject.com/en/5.0/ref/validators/#module-django.core.validators

@Scotchester

Copy link
Copy Markdown
Member Author

There's one more ref I found:

https://docs.djangoproject.com/en/5.0/ref/validators/#module-django.core.validators

Gah! Forgot to save (and thus commit) that one. Thanks.

@Scotchester
Scotchester force-pushed the docs/django-stable-links branch from ce9921c to d61b8b4 Compare March 11, 2026 19:33
@Scotchester

Copy link
Copy Markdown
Member Author

Amended.

@thekaveman thekaveman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

@Scotchester
Scotchester merged commit be4e7b3 into main Mar 11, 2026
18 checks passed
@Scotchester
Scotchester deleted the docs/django-stable-links branch March 11, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [auto] Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants