Skip to content

chore: post terraform plan summary as PR comment - #3923

Merged
jgravois merged 4 commits into
mainfrom
chore/tf-plan-comment
Aug 4, 2026
Merged

chore: post terraform plan summary as PR comment#3923
jgravois merged 4 commits into
mainfrom
chore/tf-plan-comment

Conversation

@jgravois

@jgravois jgravois commented Jul 29, 2026

Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the actions Related to GitHub Actions workflows label Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@jgravois
jgravois force-pushed the chore/tf-plan-comment branch 3 times, most recently from 856640b to fb90e88 Compare July 30, 2026 20:43
@thekaveman

Copy link
Copy Markdown
Member

Oof... this is posting the subscription ID in cleartext, something the plan output in GHA does not do.

I don't know why, I don't know if there's something we can do about that? Ideally we aren't printing it if we can avoid doing so.

@cal-itp cal-itp deleted a comment from github-actions Bot Jul 30, 2026
@jgravois

jgravois commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

good catch @thekaveman. @lalver1 and i just noticed the same exact thing. 🤦‍♂️

i deleted the PR comment. annoyingly, the copy of the summary that is appended to the job itself does obscure our azure subscription id. i suspect this is because GitHub itself filters out strings that match repo secrets there.

https://github.com/cal-itp/benefits/actions/runs/30582336772/attempts/1#summary-91005402263

if only these summaries outlived the logs themselves...

@github-actions

This comment was marked as outdated.

@jgravois

Copy link
Copy Markdown
Member Author

alright, i ended up changing tack slightly in this PR. my modified proposal is outlined in #3926 (comment)

@jgravois
jgravois marked this pull request as ready for review July 31, 2026 21:54
@jgravois
jgravois requested a review from a team as a code owner July 31, 2026 21:54
@jgravois
jgravois force-pushed the chore/tf-plan-comment branch from ea29262 to 9f86209 Compare August 3, 2026 20:39
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
CHANGE RESOURCE
update (4) azurerm_key_vault_access_policy.devsecops
azurerm_key_vault_access_policy.engineering
azurerm_key_vault_access_policy.pgadmin_container_app
azurerm_key_vault_access_policy.web_container_app
CHANGE OUTPUT
update (1) outbound_ip_ranges

@jgravois jgravois added the infrastructure Terraform, Azure, etc. label Aug 4, 2026
@cal-itp cal-itp deleted a comment from github-actions Bot Aug 4, 2026
@jgravois
jgravois force-pushed the chore/tf-plan-comment branch from 3392b2d to 9ea1226 Compare August 4, 2026 18:18
@jgravois
jgravois marked this pull request as draft August 4, 2026 18:20
@jgravois
jgravois force-pushed the chore/tf-plan-comment branch from 9ea1226 to 614e369 Compare August 4, 2026 18:23
@jgravois
jgravois marked this pull request as ready for review August 4, 2026 18:26
@jgravois

jgravois commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

i just pushed 614e369 ae8b4b6 to wire up 'sticky' comment behavior.

@thekaveman thekaveman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lovin' it 🍔

@jgravois

jgravois commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

if 'Update with rebase' dismisses your approvals, i apologize in advance 😈

@jgravois
jgravois force-pushed the chore/tf-plan-comment branch from 614e369 to ae8b4b6 Compare August 4, 2026 22:17
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Preview url: https://benefits-3923--cal-itp-previews.netlify.app

@jgravois
jgravois merged commit 2a25470 into main Aug 4, 2026
16 checks passed
@jgravois
jgravois deleted the chore/tf-plan-comment branch August 4, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions Related to GitHub Actions workflows infrastructure Terraform, Azure, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summarize 'terraform plan' output in a PR comment

3 participants