chore: upgrade azurerm to 5.0.1 - #3981
Conversation
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
| *.tfstate.* | ||
|
|
||
| # Crash log files | ||
| core |
There was a problem hiding this comment.
this is a binary file that can be generated when terraform encounters an uncaught exception.
| sku_name = "standard" | ||
| tenant_id = data.azurerm_client_config.current.tenant_id | ||
| purge_protection_enabled = true | ||
| rbac_authorization_enabled = false |
There was a problem hiding this comment.
newly required property
| name = "CAE-CDT-PUB-VIP-CALITP-${var.env_letter}-001" | ||
| location = var.location | ||
| resource_group_name = var.resource_group_name | ||
| logs_destination = "log-analytics" |
| resource "azurerm_private_dns_zone_virtual_network_link" "db" { | ||
| name = "db-link-${lower(local.env_letter)}" | ||
| resource_group_name = data.azurerm_resource_group.main.name | ||
| private_dns_zone_name = azurerm_private_dns_zone.db.name |
There was a problem hiding this comment.
deprecated (in favor of "private_dns_zone_id")
There was a problem hiding this comment.
was it intentional to lose the resource_group_name as well?
There was a problem hiding this comment.
i take that back. totally intentional. 😎
The
resource_group_nameproperty has been removed in favour of theprivate_dns_zone_idproperty. (ref)
| content { | ||
| service = service_endpoint.value | ||
| } | ||
| } |
There was a problem hiding this comment.
this bit wasn't nearly as explicit as everything else in the upgrade guide.
what gemini suggested appears to be equivalent, but i have to admit my level of understanding of our networking is shaky at best.
There was a problem hiding this comment.
Yeah this looks right to me too. I wonder if possible to make the default service_endpoints value [] (above in locals) to avoid this ternary, but nbd.
Ref: https://developer.hashicorp.com/terraform/language/expressions/dynamic-blocks
| azurerm = { | ||
| source = "hashicorp/azurerm" | ||
| version = "~> 4.67" | ||
| version = "~> 5.0.1" |
There was a problem hiding this comment.
Is there a way to configure @dependabot to watch this version?
There was a problem hiding this comment.
2 participants
resolves #3978
gemini helped me parse planning errors and make the necessary tweaks to account for breaking changes in azurerm@5.x.
as you can see from the plan summary below, merging this PR would result in "No changes" to the
devenvironment.ref: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/5.0-upgrade-guide