Handle linkchecker result discovered in this week's check - #975
Merged
Conversation
Local 11ty doesn't execute the Netlify redirects we have set up.
✅ Deploy Preview for cal-itp-mobility-marketplace ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #973
At some point between testing this a week or two ago and today, the Google Tag Manager URL started returning a 500 if something tries to access it directly. (It still results in a 200 when requested by the actual site.) This resulted in a linkchecker finding during yesterday's weekly check.
This PR handles it by just ignoring all URLs with
googletagmanagerin them.It also updates an extant link to
/contact, which I discovered that when testing this fix. Eleventy doesn't inherently support our Netlify_redirectsfile, so it was 404ing locally.