Skip to content

Update dependencies for mid-2021#188

Open
MichaelTamaki wants to merge 2 commits into
mainfrom
issue-187-update
Open

Update dependencies for mid-2021#188
MichaelTamaki wants to merge 2 commits into
mainfrom
issue-187-update

Conversation

@MichaelTamaki

Copy link
Copy Markdown
Collaborator

Description

Fixes issue #187

Updates dependencies in package.json and package-lock.json. Bump NodeJS version in Github Actions to 14 from 12.

Reviewers: Please pull this branch, run npm ci, and verify that everything works locally!

Pre-PR checklist

  • Ran npm run serve and:
    • Checked basic functionality
    • Checked that errors are handled
  • Ran npm run lint
  • Ran npm run test:unit
  • Ran npm run test:e2e and ran relevant tests
  • Attached reviewers to PR and pinged on Slack/email

@adhamrait adhamrait left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vhlee7 vhlee7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mac and it works for me.

@samuel-stahl samuel-stahl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on Windows, approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants