Fix/use common schemas#123
Conversation
70a67e6 to
8a442d9
Compare
|
@jimfengjinhua I removed @camaraproject/release-management_reviewers from the reviewer list as this is not a Release Review PR and volunteered myself to review. |
|
The changes are looking good, one point which need an explicit documentation within the PR description (and later in CHANGELOG):
|
@hdamker thanks for your prompt review and comment. I have updated PR with the API contract change explicitly described, as well as in 'Changelog input' accordingly |
…AMARA_common.yaml Remove all local definitions of XCorrelator, ErrorInfo, Device, Area, Point, and x-correlator header/parameter that duplicate CAMARA_common.yaml schemas. All references now point directly to ../common/CAMARA_common.yaml.
8a442d9 to
fe9e233
Compare
Removing X-Total-Count and Content-Last-Key headers, which should not be added.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
To replace local common data type definitions with direct $ref to
CAMARA_common.yaml. Remove all local definitions ofXCorrelator,ErrorInfo,Device,Area,Point, andx-correlatorheader/parameter that duplicateCAMARA_common.yamlschemas. All references point directly to../common/CAMARA_common.yaml.Note: The
dedicated-network-areas.yamlis now using the common data typeArea, which consequently introduced an API contract change forCircle.radius:integer200000Area)numberWhich issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
Additional documentation: