enhance: Address schema in webrtc-call-handling#178
Open
teikuran wants to merge 4 commits into
Open
Conversation
Expanded the description for Subscriber address to include supported formats and usage of anonymous SIP URI.
Clarified handling of anonymous call origination in the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded the description for Subscriber address to include supported formats and usage of anonymous SIP URI.
What type of PR is this?
What this PR does / why we need it:
This PR extends the Address schema to support anonymous call origination.
Main change — anonymous call origination:
The reserved value sip:anonymous@anonymous.invalid, as defined in RFC 3323, is added to the Address schema. When this value is set as the originatorAddress, the session is handled as an anonymous call origination and the originator's identity is not presented to the receiver. The value is restricted to originatorAddress and must not be used as receiverAddress.
Supplementary change — home local numbers in the pattern:
While updating the pattern, support for home local numbers (3GPP TS 24.229 subclause 5.1.2A.1.5) has been added, in both tel URI form and SIP URI form.
Which issue(s) this PR fixes:
Fixes #177
Special notes for reviewers:
The following formats are supported:
A TEL URI :
phone-contextparameter identifying the home network numbering plan.A SIP URI
user=phone). The user part MAY contain a home local number qualified by aphone-contextparameter, in which case theuser=phoneURI parameter SHALL be appended;sip:anonymous@anonymous.invalid(as defined in RFC 3323) MAY be used to indicate that the calling party identity is withheld within the trust domain. Whensip:anonymous@anonymous.invalidis set as theoriginatorAddress, the session SHALL be handled as an anonymous call origination. This value SHALL NOT be used as thereceiverAddress.Changelog input