feat(hyperv): add auth_method, kerberos_keytab, kerberos_principal config options - #430
Merged
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
jlocash
force-pushed
the
jlocash/kerberos-config
branch
2 times, most recently
from
July 23, 2026 13:26
6a97484 to
b8b6ef6
Compare
jlocash
marked this pull request as ready for review
July 23, 2026 13:28
cnsnyder
requested changes
Jul 28, 2026
cnsnyder
left a comment
cnsnyder
left a comment
Member
There was a problem hiding this comment.
Overall looks good to me! Just a few things for discussion below! I don't think any are worth blocking this PR long on but if they are considered useful suggestions, I'd vote we take them and proceed!
jlocash
force-pushed
the
jlocash/kerberos-config
branch
3 times, most recently
from
July 29, 2026 13:56
5ae8676 to
2030773
Compare
…nfig options Add Kerberos authentication support to the HyperV config section. New config keys on HypervConfigSection: - auth_method (basic|kerberos, default: basic) - kerberos_keytab (optional filesystem path to a keytab file) - kerberos_principal (optional Kerberos principal string) Behavior: - auth_method=basic: preserves existing behavior; username and password remain required. - auth_method=kerberos: username and password become optional. If provided, a warning is logged that they are ignored. - kerberos_keytab/kerberos_principal set with auth_method=basic are removed with a warning. - kerberos_keytab validates the file exists and is readable. - Invalid auth_method values produce a clear validation error. Signed-off-by: Joshua Locash <jlocash@redhat.com> Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
jlocash
force-pushed
the
jlocash/kerberos-config
branch
from
July 29, 2026 14:12
2030773 to
b069e11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Kerberos authentication support to the HyperV config section.
New config keys on HypervConfigSection:
auth_method(basic|kerberos, default:basic)kerberos_keytab(optional filesystem path to a keytab file)kerberos_principal(optional Kerberos principal string)Behavior:
NOTE: These changes do not fully implement kerberos authentication in virt-who. Rather, this PR includes only changes to the config file. As such, there is not an easy way to test these changes, hence the feature branch. I will follow up with another PR with the remaining work
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com