fix: handle str message decode in ESX Request/Reply unicode method - #432
Open
DuckBoss wants to merge 1 commit into
Open
fix: handle str message decode in ESX Request/Reply unicode method#432DuckBoss wants to merge 1 commit into
DuckBoss wants to merge 1 commit into
Conversation
Request.__unicode__() and Reply.__unicode__() unconditionally called
.decode("raw_unicode_escape") on self.message, which fails with
AttributeError on Python 3.14+ when message is a str rather than bytes.
This broke 24 suds transport tests on Fedora latest (Python 3.14)
where pytest's log capture eagerly formats the log arguments.
Guard .decode() with an isinstance(message, bytes) check so both
str and bytes messages are handled correctly.
Assisted-by: Cursor
Signed-off-by: Jason Jerome <jajerome@redhat.com>
Author
|
Fixes pytest failures that show up in this PR: #431 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request.unicode() and Reply.unicode() unconditionally called .decode("raw_unicode_escape") on self.message, which fails with AttributeError on Python 3.14+ when message is a str rather than bytes. This broke 24 suds transport tests on Fedora latest (Python 3.14) where pytest's log capture eagerly formats the log arguments.
Guard .decode() with an isinstance(message, bytes) check so both str and bytes messages are handled correctly.
Assisted-by: Cursor