feat(api): Docker, env loading, secrets removal, route cleanup (Phase 3 — T3.0–T3.4) - #3
Open
canonical-muhammadbassiony wants to merge 1 commit into
Conversation
T3.0: Dockerfile (golang:1.22 builder + debian:bookworm-slim runtime) with gh CLI T3.0: .dockerignore excludes .env.local, secrets, build artifacts T3.0: Taskfile docker-build and docker-run tasks T3.1: godotenv loads .env then .env.local at API startup (optional files) T3.1: .env committed with non-sensitive defaults T3.2: APIRequest no longer accepts credentials or github_token fields T3.2: handler reads creds from BAUER_CREDENTIALS_PATH env var T3.3: /api/v1/workflow renamed to /api/v1/workflows T3.3: Go 1.22 method+path routing, routes consolidated T3.4: build-api Taskfile task added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establishes the API foundation: Docker support,
.envfile loading, secrets removed from request bodies, and route consolidation.Tasks Implemented
Dockerfile(golang:1.22 builder + debian:bookworm-slim runtime with git, curl, GitHub CLI)..dockerignoreexcludes secrets and build artifacts.docker-buildanddocker-runTaskfile tasks added.github.com/joho/godotenvinstalled;cmd/app/main.goloads.envthen.env.localbeforerun()..envcommitted with non-sensitive defaults.GitHubToken,Credentials,OutputDir,LocalRepoPathfromAPIRequest. Handler resolves GitHub token viagithub.GetGitHubToken()and credentials fromBAUER_CREDENTIALS_PATH/GOOGLE_APPLICATION_CREDENTIALS.firstNonEmpty/firstNonZerohelpers for request-overrides-env semantics./api/v1/workflowtoPOST /api/v1/workflowsusing Go 1.22 method+path routing.build-apitask already present from prior branch.Security
.env.localexcluded from Docker image and gitFiles Changed
Dockerfile,.dockerignore— newTaskfile.yml—docker-build,docker-runtasks.env— committed non-sensitive defaultscmd/app/main.go— godotenv loading, route renameinternal/workflow/api.go— secrets removed fromAPIRequestgo.mod/go.sum—godotenvdependencyHow to Review
git diff feat/figma-phase-e-drift..feat/phase-3-api-foundation -- .Part of the Bauer v2 stacked PR series (Branch 9 of 12).