Skip to content

fix(WD-36308): phone field dropdown bugs - #2507

Merged
muhammad-ali-pk merged 6 commits into
mainfrom
WD-36308
Jun 3, 2026
Merged

fix(WD-36308): phone field dropdown bugs#2507
muhammad-ali-pk merged 6 commits into
mainfrom
WD-36308

Conversation

@muhammad-ali-pk

@muhammad-ali-pk muhammad-ali-pk commented May 5, 2026

Copy link
Copy Markdown
Contributor

Done

  • Fixed the telephone input dropdown width issue (matches the setup on ubuntu.com)

QA

  • Checkout this pull request
  • Run the site using the command dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8002#get-in-touch
  • Scroll down to telephone input field, click the country flag and verify the dropdown width is full width.

Issue / Card

Fixes WD-36308

@webteam-app

Copy link
Copy Markdown

@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.58%. Comparing base (27c8702) to head (f607677).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2507   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          16       16           
  Lines        1975     1975           
=======================================
  Hits         1552     1552           
  Misses        423      423           
Flag Coverage Δ
python 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@muhammad-ali-pk muhammad-ali-pk changed the title fix: phone field dropdown bugs fix(WD-36308): phone field dropdown bugs May 5, 2026
@muhammad-ali-pk
muhammad-ali-pk marked this pull request as ready for review May 5, 2026 06:38
@Skazitron

Skazitron commented May 6, 2026

Copy link
Copy Markdown
Contributor

@muhammad-ali-pk this opens a search bar when you click on the flag for the phone field. Is this expected? Might be worth checking with @Sophie-32

@muhammad-ali-pk

Copy link
Copy Markdown
Contributor Author

@Skazitron It's behaving the same way on ubuntu.com#get-in-touch, and is expected.

@Skazitron

Copy link
Copy Markdown
Contributor

@muhammad-ali-pk I see, I was concerned since it's not a feature on canonical.com. Aside from that, it also seems to be a little longer than the width of the field right now. Is there a way we can fix that?

Copilot AI review requested due to automatic review settings May 26, 2026 11:03
@muhammad-ali-pk

Copy link
Copy Markdown
Contributor Author

@Skazitron please have another look, should be fixed now.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@petesfrench

Copy link
Copy Markdown
Contributor

@muhammad-ali-pk Selecting a new country code closes the contact us modal

@muhammad-ali-pk

Copy link
Copy Markdown
Contributor Author

@petesfrench Fixed. Can you please take another look?

@petesfrench petesfrench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some testing would be nice, but can be tackled separately as not to block this.

@muhammad-ali-pk

Copy link
Copy Markdown
Contributor Author

@petesfrench Thank you!

Some testing would be nice

Are you referring to tests specific to this mobile input field, or form modals in general? I'll create a separate ticket with a detailed description after hearing your thoughts.

@muhammad-ali-pk
muhammad-ali-pk merged commit 6e494f2 into main Jun 3, 2026
13 of 15 checks passed
@muhammad-ali-pk
muhammad-ali-pk deleted the WD-36308 branch June 3, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants