fix(WD-36308): phone field dropdown bugs - #2507
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
=======================================
Coverage 78.58% 78.58%
=======================================
Files 16 16
Lines 1975 1975
=======================================
Hits 1552 1552
Misses 423 423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@muhammad-ali-pk this opens a search bar when you click on the flag for the phone field. Is this expected? Might be worth checking with @Sophie-32 |
|
@Skazitron It's behaving the same way on ubuntu.com#get-in-touch, and is expected. |
|
@muhammad-ali-pk I see, I was concerned since it's not a feature on canonical.com. Aside from that, it also seems to be a little longer than the width of the field right now. Is there a way we can fix that? |
|
@Skazitron please have another look, should be fixed now. |
|
@muhammad-ali-pk Selecting a new country code closes the contact us modal |
|
@petesfrench Fixed. Can you please take another look? |
petesfrench
left a comment
There was a problem hiding this comment.
LGTM. Some testing would be nice, but can be tackled separately as not to block this.
|
@petesfrench Thank you!
Are you referring to tests specific to this mobile input field, or form modals in general? I'll create a separate ticket with a detailed description after hearing your thoughts. |
Done
QA
dotrunIssue / Card
Fixes WD-36308