Skip to content

refactor: /events/canonical-days - #2518

Merged
Skazitron merged 2 commits into
mainfrom
WD-36239-dev-refresh-https-canonical-com-events-canonical-days
May 11, 2026
Merged

refactor: /events/canonical-days#2518
Skazitron merged 2 commits into
mainfrom
WD-36239-dev-refresh-https-canonical-com-events-canonical-days

Conversation

@Skazitron

@Skazitron Skazitron commented May 11, 2026

Copy link
Copy Markdown
Contributor

Done

  • Updated the /events/canonical-days page
  • Added new 'Event name' column to the table
  • NOTE: the 'Show all events' button works as expected. It is only displayed when the number of events exceed 4.

QA

  • Open the demo
  • Navigate to the /events/canonical-days page
  • Click on different elements on the table
  • Ensure they all function as expected
  • Ensure the design matches the figma doc

Issue / Card

https://warthogs.atlassian.net/browse/WD-36239

Screenshots

image

@webteam-app

Copy link
Copy Markdown

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.96%. Comparing base (5ecea1f) to head (767998c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2518   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files          16       16           
  Lines        1930     1930           
=======================================
  Hits         1524     1524           
  Misses        406      406           
Flag Coverage Δ
python 78.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ataku-B Ataku-B left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Skazitron
Skazitron merged commit 507fcdf into main May 11, 2026
15 of 16 checks passed
@Skazitron
Skazitron deleted the WD-36239-dev-refresh-https-canonical-com-events-canonical-days branch May 11, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants