Skip to content

Wd 37055 css styles broken on canonical com home page on some ios mobile devices - #2608

Merged
Skazitron merged 9 commits into
mainfrom
WD-37055-css-styles-broken-on-canonical-com-home-page-on-some-ios-mobile-devices
Jun 18, 2026
Merged

Wd 37055 css styles broken on canonical com home page on some ios mobile devices#2608
Skazitron merged 9 commits into
mainfrom
WD-37055-css-styles-broken-on-canonical-com-home-page-on-some-ios-mobile-devices

Conversation

@Skazitron

@Skazitron Skazitron commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Done

  • Blog cards patch to ensure description appears below title on blog cards on mobile devices

QA

  • Visit the demo on a phone, or
  • Clone and run this branch locally
  • Get your device's IP by running ip a and your LAN IP should be next to your network interface. eg. (192.168.100.181)
  • On a separate mobile device open an incognito tab and go to <LAN_IP>:8002
  • Scroll down to 'News and insights from source' section
  • Ensure the cards look normal on phones.

Issue / Card

https://warthogs.atlassian.net/browse/WD-37055

@webteam-app

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.58%. Comparing base (0796fd9) to head (1cbfd32).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2608   +/-   ##
=======================================
  Coverage   78.58%   78.58%           
=======================================
  Files          16       16           
  Lines        1975     1975           
=======================================
  Hits         1552     1552           
  Misses        423      423           
Flag Coverage Δ
python 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@petesfrench petesfrench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On medium screens the image & content should be side by side like this:

Image

Comment thread static/sass/_pattern_homepage.scss Outdated
border: 1px solid rgb(255 255 255 / 10%);
padding: 0;

display: flex !important;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid the use of !important and instead use specificity

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we use !important for this, our styles don't work on phones. They just get overriden. I think we'll have to keep them in for the blog card.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petesfrench the !importants have been removed.

@Skazitron

Skazitron commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@petesfrench addressed your comments.

// iOS/Safari builds. Lay the card out with flexbox there instead — medium
// and large keep Vanilla's equal-height grid (image left / text right)
// untouched.
@media screen and (width < $breakpoint-small) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still using important

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petesfrench Sorry, looks like the changes were not pushed. I've just pushed them. Can you take a look again.

Thanks

@petesfrench petesfrench left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I am unable to test of IOS

@Skazitron
Skazitron merged commit 1de5729 into main Jun 18, 2026
15 checks passed
@Skazitron
Skazitron deleted the WD-37055-css-styles-broken-on-canonical-com-home-page-on-some-ios-mobile-devices branch June 18, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants