Wd 37055 css styles broken on canonical com home page on some ios mobile devices - #2608
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
=======================================
Coverage 78.58% 78.58%
=======================================
Files 16 16
Lines 1975 1975
=======================================
Hits 1552 1552
Misses 423 423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| border: 1px solid rgb(255 255 255 / 10%); | ||
| padding: 0; | ||
|
|
||
| display: flex !important; |
There was a problem hiding this comment.
We should avoid the use of !important and instead use specificity
There was a problem hiding this comment.
Unless we use !important for this, our styles don't work on phones. They just get overriden. I think we'll have to keep them in for the blog card.
There was a problem hiding this comment.
@petesfrench the !importants have been removed.
…home-page-on-some-ios-mobile-devices
|
@petesfrench addressed your comments. |
| // iOS/Safari builds. Lay the card out with flexbox there instead — medium | ||
| // and large keep Vanilla's equal-height grid (image left / text right) | ||
| // untouched. | ||
| @media screen and (width < $breakpoint-small) { |
There was a problem hiding this comment.
These are still using important
There was a problem hiding this comment.
@petesfrench Sorry, looks like the changes were not pushed. I've just pushed them. Can you take a look again.
Thanks
petesfrench
left a comment
There was a problem hiding this comment.
LGTM. But I am unable to test of IOS
…home-page-on-some-ios-mobile-devices
…home-page-on-some-ios-mobile-devices

Done
QA
ip aand your LAN IP should be next to your network interface. eg. (192.168.100.181)<LAN_IP>:8002Issue / Card
https://warthogs.atlassian.net/browse/WD-37055