fix: add conditional meta tag for noindex when no articles are present - #2876
Merged
Conversation
Demo
Jenkins 
demos.haus
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an SEO safeguard to the Knowledge category index template so category pages with no available articles are marked as noindex, reducing the chance of empty/placeholder pages being indexed.
Changes:
- Introduces an
extra_metatagsblock in the Knowledge category base template. - Conditionally injects
<meta name="robots" content="noindex" />when thearticleslist is empty/falsy.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2876 +/- ##
=======================================
Coverage 74.65% 74.65%
=======================================
Files 19 19
Lines 2379 2379
=======================================
Hits 1776 1776
Misses 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
britneywwc
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
QA
curl -s http://localhost:8002/knowledge/company | grep -i 'name="robots"'will return<meta name="robots" content="noindex" />curl -s http://localhost:8002/knowledge/cloud-and-infrastructure | grep -i 'name="robots"'will return nothingIssue / Card
Fixes https://warthogs.atlassian.net/browse/WD-38391