fix(lustre-ops): ignore down IPoIB devices during LNet network detection - #65
Open
dedsec-terminal wants to merge 1 commit into
Open
dedsec-terminal wants to merge 1 commit into
dedsec-terminal wants to merge 1 commit into
Conversation
dedsec-terminal
requested review from
benschwaller and
dsloanm
and removed request for
a team
September 11, 2026 20:20
Contributor
|
CI failure looks unrelated to code changes: Microceph gave |
Author
|
@dsloanm Looks like the rerun hit another env issue. Is there anything you need from me, or do we just need another rerun? Thanks! |
Contributor
Nothing needed on your end. The changes look good but we're likely being affected by the current outage: https://status.snapcraft.io. I'll start another run once the infrastructure is back up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
Summary of changes
_is_netdev_up(netdev)inlustre_ops.lnet_detectionto check the operational state of a network interface via sysfs (/sys/class/net/{netdev}/operstate)._resolve_link_netdev()to decouple RDMA link netdev resolution from filtering logic and maintain low cyclomatic complexity._rdma_interfaces()to check if the detected netdev is operationally up, skipping any interfaces whose operational state isdown.TestIsNetdevUpto test operational state checks across various sysfs conditions (up,down, missing files, and read errors).test_skips_down_netdevinTestRdmaInterfacesto ensure active RDMA devices with down network interfaces are excluded from detected LNet networks.Justification for changes
When an InfiniBand HCA / RDMA port is
ACTIVEwithLINK_UP, the corresponding IPoIB network interface (e.g.ib0) may still be administratively or operationally down. Previously,_rdma_interfaces()returned any RDMA device withstate == "ACTIVE"andphysical_state == "LINK_UP"regardless of the Linux netdev state, causing downstreamlnetctloperations to fail when attempting to configure LNet on down interfaces. Checkingoperstatein sysfs ensures only usable, active network interfaces are returned.Related Issues, PRs, and Discussions
Fixes #60
Docs
Internal bug fix in LNet hardware interface auto-detection logic.