eds: Fix typo in manufacturer_idices → manufacturer_indices#642
Open
bizfsc wants to merge 1 commit intocanopen-python:masterfrom
Open
eds: Fix typo in manufacturer_idices → manufacturer_indices#642bizfsc wants to merge 1 commit intocanopen-python:masterfrom
bizfsc wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Also use comparison instead of range() for a minor performance improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a typo in
export_eds(): renamemanufacturer_idices→manufacturer_indices(3 occurrences).Also replaces
x in range(0x2000, 0x6000)with0x2000 <= x < 0x6000for clarity and minor performance improvement.Extracted from #615 to keep that PR focused on the custom options feature.