Add unit tests for LSS master (coverage 42% → 93%)#643
Open
bizfsc wants to merge 1 commit intocanopen-python:masterfrom
Open
Add unit tests for LSS master (coverage 42% → 93%)#643bizfsc wants to merge 1 commit intocanopen-python:masterfrom
bizfsc wants to merge 1 commit intocanopen-python:masterfrom
Conversation
Add 28 unit tests covering: - Switch state global/selective commands - Node ID and bit timing configuration - Activate bit timing and store configuration - LSS address inquiry (vendor/product/revision/serial) - Timeout and error handling - Fast scan protocol - Obsolete method aliases - LssError exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 28 unit tests for
canopen/lss.pyto improve test coverage from 42% to 93%.Tests Added
LssErrorraised on missing responsessend_switch_state_globalbackward compatApproach
Uses
unittest.mock.MagicMockto mock the network layer. A helper method injects CAN responses duringsend_message()calls to simulate real LSS slave behavior, including only responding to commands that expect a reply per the protocol.Coverage