Skip to content

Fix/android load with keys crash on start #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonljus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/android load with keys crash on start #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25fe7a
fix(android): resolve promise for loadWithKeys
simonljus Jul 23, 2026
5f0c372
fix(android): prevent from crashing on start if using loadWithKeys ov…
simonljus Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 49 additions & 6 deletions android/src/main/java/com/getcapacitor/community/intercom/intercom/IntercomPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ public class IntercomPlugin extends Plugin {
private static final String EVENT_WINDOW_DID_HIDE = "windowDidHide";

private final IntercomPushClient intercomPushClient = new IntercomPushClient();


private volatile boolean isIntercomInitialized = false;
@Override
public void load() {
// Set up Intercom
Expand All @@ -50,13 +51,38 @@ public void load() {

@PluginMethod
public void loadWithKeys(PluginCall call) {
String appId = call.getString("appId", "NO_APP_ID_PASSED");
String apiKey = call.getString("apiKeyAndroid", "NO_API_KEY_PASSED");

Intercom.initialize(this.getActivity().getApplication(), apiKey, appId);
String appId = call.getString("appId");
String apiKey = call.getString("apiKeyAndroid");

if (appId == null || appId.isEmpty() || apiKey == null || apiKey.isEmpty()) {
Logger.error("Intercom", "ERROR: loadWithKeys() called without a valid appId/apiKeyAndroid");
// load parent
super.load();
call.reject("loadWithKeys() requires both appId and apiKeyAndroid");
return;
}

Exception initError = null;

try {
Intercom.initialize(this.getActivity().getApplication(), apiKey, appId);
isIntercomInitialized = true;
} catch (Exception e) {
isIntercomInitialized = false;
Logger.error("Intercom", "ERROR: Something went wrong when initializing Intercom with provided keys", e);
initError = e;
}
// load parent
super.load();

if (isIntercomInitialized) {
call.resolve();
} else {
call.reject("Failed to initialize Intercom", initError);
}



}

@Override
Expand All @@ -70,6 +96,11 @@ public void handleOnStart() {
public void run() {
//We also initialize intercom here just in case it has died. If Intercom is already set up, this won't do anything.
setUpIntercom();
if (!isIntercomInitialized) {
Logger.error("Intercom", "Skipping handlePushMessage — Intercom is not initialized");
return;
}

Intercom.client().handlePushMessage();
}
}
Expand Down Expand Up @@ -273,15 +304,27 @@ public void displayArticle(PluginCall call) {
}

private void setUpIntercom() {
if(isIntercomInitialized){
return;
}
try {
// get config
CapConfig config = this.bridge.getConfig();
String apiKey = config.getPluginConfiguration("Intercom").getString("androidApiKey");
String appId = config.getPluginConfiguration("Intercom").getString("androidAppId");

// check if keys are omitted, possibly calling loadWithKeys later
if (apiKey == null || apiKey.isEmpty() || appId == null || appId.isEmpty()) {
Logger.warn("Intercom", "WARN: androidApiKey/androidAppId missing from capacitor config, assuming the plugin method loadWithKeys() will be called, skipping Intercom.initialize()");
isIntercomInitialized = false;
return;
}

// init intercom sdk
Intercom.initialize(this.getActivity().getApplication(), apiKey, appId);
isIntercomInitialized = true;
} catch (Exception e) {
isIntercomInitialized = false;
Logger.error("Intercom", "ERROR: Something went wrong when initializing Intercom. Check your configurations", e);
}
}
Expand Down Expand Up @@ -321,4 +364,4 @@ private static List<Object> listFromJSON(JSArray jsonArray) {
}
return list;
}
}
}