Skip to content

Use string literals for ENCODED_NODE#644

Open
stepancheg wants to merge 1 commit intocapnproto:masterfrom
stepancheg:encoded-node
Open

Use string literals for ENCODED_NODE#644
stepancheg wants to merge 1 commit intocapnproto:masterfrom
stepancheg:encoded-node

Conversation

@stepancheg
Copy link
Copy Markdown
Contributor

@stepancheg stepancheg commented Mar 30, 2026

Blocks like these:

                *b"\x00\x00\x00\x00\x00\x00\x00\x00",
                *b"schema.c",
                *b"apnp:Nod",
                *b"e.Nested",
                *b"Node\x00\x00\x00\x00",
                *b"\x00\x00\x00\x00\x01\x00\x01\x00",

give a clue what is inside.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.05%. Comparing base (ab342b3) to head (efcbadd).
⚠️ Report is 288 commits behind head on master.

Files with missing lines Patch % Lines
capnp/src/lib.rs 0.00% 13 Missing ⚠️
capnpc/src/pointer_constants.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   51.64%   51.05%   -0.60%     
==========================================
  Files          69       71       +2     
  Lines       33735    32501    -1234     
==========================================
- Hits        17422    16592     -830     
+ Misses      16313    15909     -404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stepancheg stepancheg force-pushed the encoded-node branch 3 times, most recently from a83ab0f to 2c3c4d9 Compare March 30, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant