fix: panic error when release cs hook in case cs.hook is nil#610
Open
TienMinh25 wants to merge 1 commit intocapnproto:mainfrom
Open
fix: panic error when release cs hook in case cs.hook is nil#610TienMinh25 wants to merge 1 commit intocapnproto:mainfrom
TienMinh25 wants to merge 1 commit intocapnproto:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to address issue #572, as previously noted by @QuangTung97. In production, we sometimes handle around 10 million requests, and roughly 1% of them may panic when cs.hooks is nil. I haven’t been able to reproduce the issue in tests yet, but I suspect it may be caused by the defer tgt.Release() call at line 959 in /rpc/rpc.go.
