fix: [#2339] Prevent unhandled rejection in Animation.cancel() - #2340
Open
CNSeniorious000 wants to merge 3 commits into
Open
fix: [#2339] Prevent unhandled rejection in Animation.cancel()#2340CNSeniorious000 wants to merge 3 commits into
CNSeniorious000 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Animation.cancel()can fail tests with an unhandledAbortErroreven whenfinishedis never read. Following the cancellation algorithm, mark the promise handled, replace it on cancellation, and reuse the replacement on idle-to-play while preserving the old promise's rejection.Resolves #2339
Before submitting the PR, please make sure you do the following:
Tests
npm testlocally to make sure that all tests pass before submitting the PR.CI passed on Node 20, 22, and 24.
Local validation: 205 Animation/Element tests, TypeScript compilation, ESLint, and Prettier passed. Earlier Chromium 148 checks confirmed promise identity and cancellation behavior. The earlier full local run had 9 macOS canvas snapshot mismatches; the current full compile attempt hit a
chromium.googlesource.comdownload timeout.Title
feat,fix,choreorBREAKING CHANGE. The issue is optional and can be omitted if the pull request does not relate to an issue.AI tools
AI-assisted with Codex and Claude Code.