feat: [#2393] support the :valid and :invalid CSS pseudo-classes - #2394
Open
marciomazza wants to merge 1 commit into
Open
feat: [#2393] support the :valid and :invalid CSS pseudo-classes#2394marciomazza wants to merge 1 commit into
:valid and :invalid CSS pseudo-classes#2394marciomazza wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2393
:valid/:invalidare never matched —SelectorItem.matchPseudoItemhas nocase for them, so any such selector silently returns nothing.
Fix: add an
invalid/validcase. It is gated onwillValidateso it onlymatches constraint-validation candidates (skipping disabled / non-applicable
elements, as browsers do), then reflects
checkValidity().Deviation left on purpose:
:valid/:invalidare not implemented for<form>and
<fieldset>themselves (they would need aggregate validity); only individualform controls are covered.
Tests
Added 1 test:
:invalidmatches an emptyrequiredinput,:validmatches afilled one, and a
disabled requiredinput plus a<div>match neither.Fails before / passes after. Full
npm testpasses.AI
I used Claude Code to write this, over multiple iterations. I guided and reviewed
it myself at every step.
Before submitting the PR, please make sure you do the following:
Tests
:invalidmatched#aonly,:validmatched#bonly; thedisabled requiredinput and the<div>matched neither. Same as the test asserts.npm testlocally to make sure that all tests pass before submitting the PR.Title
feat,fix,choreorBREAKING CHANGE. The issue is optional and can be omitted if the pull request does not relate to an issue.AI tools