Skip to content

Enable more lint rules for skin-database - #1325

Merged
captbaritone merged 1 commit into
consolidate-eslint-configsfrom
enable-skin-database-lint-rules
Nov 28, 2025
Merged

Enable more lint rules for skin-database#1325
captbaritone merged 1 commit into
consolidate-eslint-configsfrom
enable-skin-database-lint-rules

Conversation

@captbaritone

Copy link
Copy Markdown
Owner

Summary

This PR enables additional ESLint rules for the skin-database package that were previously disabled. Stacked on top of #1324.

Rules Enabled

All root ESLint rules are now enabled except camelcase (which has 333 violations and would require major refactoring).

Rule Violations Fixed
eqeqeq 5
prefer-const 11
prefer-template 7
prefer-arrow-callback 9
no-else-return 8
no-return-await 5
no-undef-init 2
dot-notation 1
guard-for-in 0
no-div-regex 1
new-cap 2

Testing

  • All lint checks pass
  • All tests pass

Enable all root ESLint rules except camelcase (333 violations).

Rules now enabled:
- eqeqeq (strict equality)
- prefer-const
- prefer-template
- prefer-arrow-callback
- no-else-return
- no-return-await
- no-undef-init
- dot-notation
- guard-for-in
- no-div-regex
- new-cap

Fixed 51 lint violations across the package.
@github-actions

Copy link
Copy Markdown

Size Change: 0 B 🆕

Total Size: 0 B

compressed-size-action

@captbaritone
captbaritone merged commit bf11e14 into consolidate-eslint-configs Nov 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant