Skip to content

Added support for 4.06.1 and fixed build issues.#10

Open
Ninjapouet wants to merge 1 commit intocaradoc-org:masterfrom
Ninjapouet:master
Open

Added support for 4.06.1 and fixed build issues.#10
Ninjapouet wants to merge 1 commit intocaradoc-org:masterfrom
Ninjapouet:master

Conversation

@Ninjapouet
Copy link
Copy Markdown

  • Support for safe-string.
  • Removed the curses' cmx dependency for it may not be installed with opam.
  • Avoid hygiene violations with make test.

- Support for safe-string.
- Removed the curses' cmx dependency for it may not be installed with opam.
- Avoid hygiene violations with make test.
@XVilka
Copy link
Copy Markdown

XVilka commented Nov 15, 2019

Would be nice to check also the 4.07.1, 4.08.1, and 4.09.0 support.

@edwintorok
Copy link
Copy Markdown

edwintorok commented Nov 14, 2022

With OCaml 4.14.0, and the following Makefile change to avoid some new warnings (that are being treated as errors) this PR compiles and the tests run successfully:

diff --git a/Makefile b/Makefile
index 7169e46..c5eb7d1 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-OCAML_OPTS=-w,+a-3-4-32..39-58,-warn-error,+a,-strict-sequence,-noautolink
+OCAML_OPTS=-w,+a-3-4-32..39-58-44-67-69-70,-warn-error,+a,-strict-sequence,-noautolink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants