fix(button-group): remove element selector restrictions - #12291
Merged
kodiakhq[bot] merged 2 commits intoJul 24, 2025
Merged
Conversation
marcelojcs
requested review from
Valentin-Sorin-Nicolae and
bruno-amorim
and removed request for
a team
July 17, 2025 20:20
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bruno-amorim
approved these changes
Jul 24, 2025
bruno-amorim
left a comment
bruno-amorim
left a comment
Contributor
There was a problem hiding this comment.
Working fine to me too! Nice job!
marcelojcs
added
the
Ready to merge
kodiakhq
Bot
merged commit Jul 24, 2025
7206b39
into
carbon-design-system:main
20 of 22 checks passed
Contributor
|
Hey there! This issue/pull request was referenced in recently released v2.29.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
jira
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
PR to remove the restrictions on the method that defines the child count on
button-groupThe restrictions were filtering out valid components and causing the button group to misbehave.
Before:
(buttons on top of each other)
After:
(Buttons side by side)