Feat/masthead lang selector - #12309
Merged
kodiakhq[bot] merged 5 commits intoSep 4, 2025
Merged
Conversation
bruno-amorim
requested review from
Valentin-Sorin-Nicolae and
marcelojcs
and removed request for
a team
September 2, 2025 18:07
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcelojcs
added
Ready to merge
marcelojcs
approved these changes
Sep 4, 2025
kodiakhq
Bot
merged commit Sep 4, 2025
124bf6e
into
carbon-design-system:main
19 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-8762
Description
Implementation of the language selector in the Masthead's global bar:
Changelog
New files created:
Testing Instructions
Since the Storybook does not have meta tags for LC and CC, we need to emulate that. We can use this code to inject some meta tags to the Storybook through the console and then click on the globe icon to test again:
const metaCC = document.createElement('meta');metaCC.name = 'countryCode';metaCC.content = 'us';const metaLC = document.createElement('meta');metaLC.name = 'languageCode';metaLC.content = 'en';document.head.appendChild(metaCC);document.head.appendChild(metaLC);