Skip to content

ADCMS-9193/nav space for last carousel - #12312

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
Valentin-Sorin-Nicolae:ADCMS-9193-nav-space
Sep 22, 2025
Merged

ADCMS-9193/nav space for last carousel#12312
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
Valentin-Sorin-Nicolae:ADCMS-9193-nav-space

Conversation

@Valentin-Sorin-Nicolae

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

Related Ticket(s)

ADCMS-9193

Description

Carousel w/ Block Cards: Spacing missing after pagination, while horizontal line is hidden

Changelog

Adding a bottom space for the navigation when carousel is the last component on the page and <hr> is hidden.

image

@Valentin-Sorin-Nicolae
Valentin-Sorin-Nicolae requested a review from a team as a code owner September 10, 2025 14:19
@Valentin-Sorin-Nicolae
Valentin-Sorin-Nicolae requested review from bruno-amorim and marcelojcs and removed request for a team September 10, 2025 14:19
@netlify

netlify Bot commented Sep 10, 2025

Copy link
Copy Markdown

Deploy Preview for incomparable-wisp-8d6771 ready!

Name Link
🔨 Latest commit 4d7545f
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-wisp-8d6771/deploys/68d1547e3cec720008aa4fef
😎 Deploy Preview https://deploy-preview-12312--incomparable-wisp-8d6771.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 10, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 9b55853
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components-react-wrap/deploys/68c1890e7506780007c6e627
😎 Deploy Preview https://deploy-preview-12312--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 10, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 9b55853
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components/deploys/68c1890ee7a41900083e8522
😎 Deploy Preview https://deploy-preview-12312--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 10, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 4d7545f
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components-react-wrap/deploys/68d1547e11be950008cde79f
😎 Deploy Preview https://deploy-preview-12312--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Sep 10, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 4d7545f
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components/deploys/68d1547ef558520008d24bb2
😎 Deploy Preview https://deploy-preview-12312--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bruno-amorim bruno-amorim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bruno-amorim bruno-amorim added the Ready to merge Label for the pull requests that are ready to merge label Sep 22, 2025
@kodiakhq
kodiakhq Bot merged commit 7b4e3be into carbon-design-system:main Sep 22, 2025
19 of 22 checks passed
@Valentin-Sorin-Nicolae
Valentin-Sorin-Nicolae deleted the ADCMS-9193-nav-space branch September 23, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge Label for the pull requests that are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants