Fix/9630 video title translation lightbox - #12316
Merged
kodiakhq[bot] merged 7 commits intoSep 22, 2025
Merged
Conversation
This reverts commit bca35cb.
bruno-amorim
requested review from
Valentin-Sorin-Nicolae and
marcelojcs
and removed request for
a team
September 15, 2025 19:51
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcelojcs
approved these changes
Sep 22, 2025
marcelojcs
added
the
Ready to merge
kodiakhq
Bot
merged commit Sep 22, 2025
33a61c7
into
carbon-design-system:main
19 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-9630
Description
In this ticket - https://jsw.ibm.com/browse/ADCMS-7731
We wrote some logic that will hide the video title in non English pages. However, since Lightbox player uses the video player a bit differently, some adjustments were also needed here:
Changelog
New logic added to hide the video title in non EN pages