refactor: use yaci-store SyncStatusService instead of local back-port#65
Draft
matiwinnetou wants to merge 2 commits intodevelopfrom
Draft
refactor: use yaci-store SyncStatusService instead of local back-port#65matiwinnetou wants to merge 2 commits intodevelopfrom
matiwinnetou wants to merge 2 commits intodevelopfrom
Conversation
Remove OnchainSyncStatusService (ported from yaci-store admin-ui) and use the upstream SyncStatusService now available in yaci-store-core as of 2.0.1 (bloxbean/yaci-store#861). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
matiwinnetou
changed the title
12 tasks
matiwinnetou
force-pushed
the
refactor/use-yaci-store-sync-status
branch
2 times, most recently
from
ea1102c to
185f9d8
Compare
Resolve conflicts: keep deleted OnchainSyncStatusService (replaced by upstream), keep develop's health indicator using getSyncPercentage(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
matiwinnetou
force-pushed
the
refactor/use-yaci-store-sync-status
branch
from
185f9d8 to
479d085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Summary
OnchainSyncStatusService(ported/duplicated sync logic) and its tests (-295 lines)SyncStatusServicefromyaci-store-corewithgetSyncStatus()returning aSyncStatusrecord (synced(),syncPercentage())version.yacifrom2.0.0to2.0.1Depends on: bloxbean/yaci-store#861 being merged and released as 2.0.1
What changed
OnchainSyncStatusServiceback-port (~200 lines) with manual chain tip polling, cachedNetworkTip, and percentage calculationSyncStatusService.getSyncStatus()returningSyncStatusrecordgetSyncPercentage()+isSynced()(two calls)getSyncStatus()→syncStatus.syncPercentage()+syncStatus.synced()(single call)Test plan
OnchainReadinessHealthIndicatorreports correct sync status (UP/OUT_OF_SERVICE/DOWN)/actuator/health/livenessand/actuator/health/readinessinclude sync percentageSyncStatusIntegrationIT).decimal separator regardless of JVM locale