fix(pcl_recorder): Add missing tf2_eigen dependencies for ROS 2 build#761
Open
Jiangxumin wants to merge 5 commits into
Open
fix(pcl_recorder): Add missing tf2_eigen dependencies for ROS 2 build#761Jiangxumin wants to merge 5 commits into
Jiangxumin wants to merge 5 commits into
Conversation
added 5 commits
November 3, 2025 19:20
- Add tf2, tf2_ros, tf2_eigen, tf2_geometry_msgs to package.xml for ROS 2 - Link tf2_eigen and tf2_geometry_msgs in ament_target_dependencies - Resolves compilation error: tf2_eigen/tf2_eigen.h: No such file or directory"
- Replace numpy.bool with numpy.bool_ in DVSCamera - Fixes compatibility with NumPy >= 1.20 - Resolves AttributeError: module 'numpy' has no attribute 'bool'
- Skip map reload when the same map is already loaded - Handle map name comparison for both short names and full paths - Add informative log message when skipping map reload"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The pcl_recorder package failed to compile in ROS 2 with the error:
Solution
tf2,tf2_ros,tf2_eigen,tf2_geometry_msgs) topackage.xmltf2_eigenandtf2_geometry_msgsinament_target_dependenciesinCMakeLists.txtChanges
package.xml: Added tf2-related dependencies for ROS 2CMakeLists.txt: Updated ament_target_dependencies to include tf2_eigen and tf2_geometry_msgsTesting
colcon build --packages-select pcl_recorderThis change is