Slack Blocks API support using notify(...body_format="json") #1337
Open
operatorequals wants to merge 2 commits intocaronc:masterfrom
Open
Slack Blocks API support using notify(...body_format="json") #1337operatorequals wants to merge 2 commits intocaronc:masterfrom
notify(...body_format="json") #1337operatorequals wants to merge 2 commits intocaronc:masterfrom
Conversation
b8ef3dc to
8d27ae9
Compare
|
Nice! Looks good to me |
Owner
|
I get the direction you're going with this.... Apprise to handle to overhead of setting up all of the connection overhead to where you provide the raw data yourself. To make this more flexible so people cna make custom discord, telegram, and other raw over-rides... it may be better to not use Also... more thought is needed i think as input cna be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #641
This PR works towards the comment found here: #641 (comment)
As AppRise does not handle templating universally, it is possible that users have their templates in their code. This PR makes it possible to pass JSON string to
bodyof the Slack plugin to utilize the Blocks API.As a result, this code should work:
This will honour the
titleas well asfooterandcolorset by thenotify_type.Finally, the code will fail if the
blocksparameter is NOT set in the URL.Checklist
flake8)Testing
Anyone can help test this source code as follows: