Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 197 197
Lines 26067 26223 +156
Branches 4253 4274 +21
==========================================
+ Hits 26067 26223 +156
🚀 New features to boost your workflow:
|
5 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end (E2E) encryption support to the existing Threema Gateway (threema://) plugin, keeping the current “basic” (server-side encryption) mode intact while introducing an optional PyNaCl-based client-side encryption path.
Changes:
- Add E2E mode (
mode=e2e) with client-side NaCl encryption, public-key lookup, and caching inNotifyThreema. - Add PyNaCl as an optional dependency for “all plugins” installs and RPM packaging metadata.
- Add an extensive test suite covering mode selection, key parsing, URL round-trips, E2E send paths, caching, and failure handling.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
apprise/plugins/threema.py |
Implements E2E mode, optional PyNaCl import, pubkey fetch/cache, encryption, and URL parsing/formatting updates. |
tests/test_plugin_threema.py |
Adds new tests for mode detection, key parsing, URL behavior, E2E send/caching, and error scenarios. |
pyproject.toml |
Adds PyNaCl to the all-plugins optional dependency extra. |
all-plugin-requirements.txt |
Adds PyNaCl to the aggregated plugin requirements list. |
packaging/redhat/python-apprise.spec |
Adds python3dist(pynacl) to RPM BuildRequires/Recommends. |
bin/build-rpm.sh |
Installs spec build dependencies via dnf builddep before building RPMs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue (if applicable): #986
Add end-to-end encrypted messaging support to the Threema Gateway plugin
(
threema://).How it works:
?mode=e2e) — encrypts messages client-side.private:{64hexchars}(Threema SDK format) or a raw 64-char hex string.Checklist
tox -e lintand optionallytox -e format).tox -e qa).Testing
Anyone can help test as follows: