Open
Conversation
Owner
Author
|
This is ready to go; i just need someone who has an Octopush account to test this out for me! if they could let me know; that would be fantastic! 🚀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 202 203 +1
Lines 27591 27736 +145
Branches 4533 4557 +24
==========================================
+ Hits 27591 27736 +145
🚀 New features to boost your workflow:
|
fdaa945 to
7ee9cbe
Compare
9c83973 to
2b4899e
Compare
3f09993 to
3c9ccfd
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new Octopush notification backend to Apprise (including URL syntax support, batching options, and related documentation/packaging updates).
Changes:
- Introduces
NotifyOctopushplugin implementing Octopush SMS delivery (URL parsing, batching, replies, purpose/type options). - Adds comprehensive unit tests covering URL parsing/validation and batching behavior.
- Updates user-facing and packaging metadata to list Octopush as a supported service.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apprise/plugins/octopush.py |
New Octopush notification plugin implementation (parsing, payload creation, request/response handling, batching). |
tests/test_plugin_octopush.py |
New test suite validating URL handling, parameter parsing, request payloads, and batch splitting. |
README.md |
Adds Octopush to the supported services table with example URL formats. |
packaging/redhat/python-apprise.spec |
Updates RPM description list to include Octopush. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): n/a
Added Octopush support
You need to have an account with Octopush and generate/access your API key.
Syntax
Valid syntax is as follows:
octopush://{api_login}/{api_key}/{target_phone_no}octopush://{sender}:{api_login}/{api_key}/{target_phone_no}octopush://{api_login}/{api_key}/{target_phone_no1}/{target_phone_no2}/{target_phone_noN}octopush://{sender}:{api_login}/{api_key}/{target_phone_no1}/{target_phone_no2}/{target_phone_noN}Parameter Breakdown
sms_premium(which is the default if nothing is specified) orsms_low_costalert(which is the default if not specified) orwholesale.yesfor getting back recipient replies; by default this is set tonoNew Service Completion Status
%global common_descriptionChecklist
flake8)Testing
Anyone can help test this source code as follows: