[DNM] [DNR] Accessibility order markers#263
Draft
RoyalPineapple wants to merge 5 commits intomainfrom
Draft
Conversation
RoyalPineapple
force-pushed
the
alex/orderMarkers
branch
from
09d9904 to
4f0629a
Compare
RoyalPineapple
changed the title
RoyalPineapple
commented
Sep 18, 2025
Collaborator
Author
There was a problem hiding this comment.
These markers may be too subtle, its a delicate balance. I don't want to overpower the element under test.
RoyalPineapple
commented
Sep 23, 2025
| #endif | ||
|
|
||
|
|
||
| public struct AccessibilitySnapshotConfiguration { |
Collaborator
Author
There was a problem hiding this comment.
This struct just collects the configuration variables used in the codebase without much thought put into it.
We could take this as an opportunity to structure them a bit better. possibly to differentiate rendering options (monochrome) from legend verbosity (input labels) and overlay options (activation point, order markers).
Collaborator
There was a problem hiding this comment.
As discussed earlier, let's break this down into sub-configuration objects and pull the configuration out into its own PR
RoyalPineapple
force-pushed
the
alex/orderMarkers
branch
from
b231582 to
58164f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds overlay markers that explicitly expose the accessibility sort order providing greater accessibility for colorblind users.
This can be also be useful to quickly validate ordering without needing to continually reference the legend view.