5.0.1-beta-3#114
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request downgrades the SDK version from 5.1.0 to 5.0.1-beta-3, representing a significant rollback to a beta version. The changes include API version rollback, dependency version updates, and removal of several API features and interfaces.
Changes:
- Version downgrade from 5.1.0 to 5.0.1-beta-3 with OpenAPI document version rollback from 2025-01-01 to 2023-08-01
- Dependency updates with multiple nonexistent/future package versions
- Removal of various API interfaces, fields, and features including PAR creation, product configurations, and payment filtering capabilities
- Breaking changes to API signatures including type changes and required field modifications
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 91 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Version downgrade to beta, dependency updates with nonexistent versions |
| index.ts | OpenAPI document version rollback to 2023-08-01 |
| configuration.ts | OpenAPI document version rollback to 2023-08-01 |
| common.ts | OpenAPI document version rollback to 2023-08-01 |
| base.ts | OpenAPI document version rollback to 2023-08-01 |
| api.ts | Major API changes: interface removals, type changes, field requirement changes, new QR code APIs, breaking changes to subscription and terminal APIs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * Cashfree\'s Payment Gateway APIs provide developers with a streamlined pathway to integrate advanced payment processing capabilities into their applications, platforms and websites. | ||
| * | ||
| * The version of the OpenAPI document: 2025-01-01 | ||
| * The version of the OpenAPI document: 2023-08-01 |
There was a problem hiding this comment.
The OpenAPI document version is being changed from "2025-01-01" to "2023-08-01", indicating a rollback to an older API version. This is a breaking change that may affect API compatibility and should be documented in the PR description.
| * The version of the OpenAPI document: 2023-08-01 | |
| * The version of the OpenAPI document: 2025-01-01 |
| @@ -9618,7 +8529,7 @@ export interface TerminalDetails { | |||
| * @type {string} | |||
| * @memberof TerminalDetails | |||
| */ | |||
| 'terminal_phone_no'?: string; | |||
| 'terminal_phone_no': string; | |||
There was a problem hiding this comment.
The terminal_phone_no field is changed from optional to required (removed the ?). This is a breaking API change that could cause compilation errors for existing code that doesn't provide this field.
| 'terminal_phone_no': string; | |
| 'terminal_phone_no'?: string; |
| * @type {string} | ||
| * @memberof CreateSubscriptionRefundRequest | ||
| */ | ||
| 'cf_payment_id'?: string; |
There was a problem hiding this comment.
The cf_payment_id field type is changed from number to string in CreateSubscriptionRefundRequest. This is a breaking change that will cause type errors in existing code.
| * @type {string} | |
| * @memberof CreateSubscriptionRefundRequest | |
| */ | |
| 'cf_payment_id'?: string; | |
| * @type {string | number} | |
| * @memberof CreateSubscriptionRefundRequest | |
| */ | |
| 'cf_payment_id'?: string | number; |
| @@ -7060,7 +6410,7 @@ export interface PaymentWebhookErrorEntity { | |||
| 'error_description_raw'?: string; | |||
| } | |||
| /** | |||
| * payment gateway details present in the webhook response | |||
| * payment gatewat details present in the webhook response | |||
There was a problem hiding this comment.
Typo in comment: "gatewat" should be "gateway".
| * payment gatewat details present in the webhook response | |
| * payment gateway details present in the webhook response |
| * @interface CreateSubscriptionPaymentRequestEnack | ||
| */ | ||
| export interface CreateSubscriptionPaymentRequestEnach { | ||
| export interface CreateSubscriptionPaymentRequestEnack { |
There was a problem hiding this comment.
Interface name typo: "CreateSubscriptionPaymentRequestEnach" should be "CreateSubscriptionPaymentRequestEnack" (changed from "Enach" to "Enack"). While this appears to be a fix, it's still a breaking change as existing code using the old interface name will fail.
| @@ -18138,7 +17217,7 @@ const TokenVaultApiAxiosParamCreator = function (cashfree: Cashfree) { | |||
|
|
|||
|
|
|||
|
|
|||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.1.0'; | |||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.0.1-beta-3'; | |||
| if (x_api_version != null && x_api_version != undefined) { | |||
There was a problem hiding this comment.
This guard always evaluates to true.
| @@ -18210,7 +17289,7 @@ const TokenVaultApiAxiosParamCreator = function (cashfree: Cashfree) { | |||
|
|
|||
|
|
|||
|
|
|||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.1.0'; | |||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.0.1-beta-3'; | |||
| if (x_api_version != null && x_api_version != undefined) { | |||
There was a problem hiding this comment.
This guard always evaluates to true.
| @@ -18285,7 +17364,7 @@ const TokenVaultApiAxiosParamCreator = function (cashfree: Cashfree) { | |||
|
|
|||
|
|
|||
|
|
|||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.1.0'; | |||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.0.1-beta-3'; | |||
| if (x_api_version != null && x_api_version != undefined) { | |||
There was a problem hiding this comment.
This guard always evaluates to true.
| @@ -18357,7 +17436,7 @@ const TokenVaultApiAxiosParamCreator = function (cashfree: Cashfree) { | |||
|
|
|||
|
|
|||
|
|
|||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.1.0'; | |||
| localVarHeaderParameter['x-sdk-platform'] = 'nodejssdk-5.0.1-beta-3'; | |||
| if (x_api_version != null && x_api_version != undefined) { | |||
There was a problem hiding this comment.
This guard always evaluates to true.
| */ | ||
|
|
||
|
|
||
|
|
||
|
|
||
| class Environment { |
There was a problem hiding this comment.
Unused class Environment.
Raising PR to github