docker hard image#2078
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
+ Coverage 69.08% 70.18% +1.09%
==========================================
Files 352 355 +3
Lines 69568 71119 +1551
==========================================
+ Hits 48064 49914 +1850
+ Misses 21504 21205 -299 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| SQLITE_TMPDIR=/data \ | ||
| TMPDIR=/data |
There was a problem hiding this comment.
Don't we want to create /tmp too and point SQLITE_TMPDIR and TMPDIR there?
Mixing data files and temp files together sounds bad.
There was a problem hiding this comment.
I think you are right. We probably don't have to create the directory at all.
I'm going to update this. Thanks.
cdk-bot
left a comment
There was a problem hiding this comment.
Verified findings approved for disclosure:
- README references nonexistent docker-compose.hardened.yaml (low) - Users following the new hardened-image Compose instructions will fail with a missing compose file and have no in-repo compose configuration applying the described hardening flags.
| cashubtc/mintd:latest-hardened | ||
| ``` | ||
|
|
||
| Or use the Compose file that applies the same runtime hardening: |
There was a problem hiding this comment.
The new hardened-image README section points users to docker-compose -f docker-compose.hardened.yaml up, but this PR only adds Dockerfile.hardened and no docker-compose.hardened.yaml exists in the repository. Users following the documented Compose workflow will hit a missing-file error. Please either add the referenced Compose file with the runtime hardening settings described here, or remove/adjust this paragraph.
Description
docker image without
/bin/shbuilt from scratch image.Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)