Fix auth wallet fetch#2200
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
- Coverage 73.75% 73.56% -0.19%
==========================================
Files 359 360 +1
Lines 81144 81432 +288
==========================================
+ Hits 59851 59909 +58
- Misses 21293 21523 +230 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
crodas
previously approved these changes
Jul 4, 2026
3fab7c7 to
023220f
Compare
Collaborator
Author
|
@cdk-bot review |
cdk-bot
reviewed
Jul 6, 2026
cdk-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verified findings approved for disclosure:
- New required Transport methods break downstream implementors (medium) - External crates implementing the public cdk-http-client Transport trait will fail to compile after upgrading unless they add the two new required methods.
Unanchored locations included in summary:- crates/cdk-http-client/src/transport/mod.rs:45
- New wallet auth/OIDC APIs are not reflected in cdk-ffi (low) - Foreign-language users of cdk-ffi cannot access or configure the new wallet authentication/OIDC API added by the PR, leaving FFI bindings out of sync with the Rust wallet API.
Additional locations included in summary:- crates/cdk/src/wallet/builder.rs:134
1ed3520 to
d9cb15c
Compare
Collaborator
Author
|
@cdk-bot review |
cdk-bot
reviewed
Jul 6, 2026
cdk-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verified findings approved for disclosure:
- Existing custom transports can silently lose OIDC support (low) - Wallets using BaseHttpClient/HttpClient with an existing custom Transport can compile unchanged but lose OIDC functionality at runtime unless they add the new raw GET and form POST methods.
Additional locations included in summary:- crates/cdk-http-client/src/transport/mod.rs:72
- crates/cdk/src/wallet/mint_connector/http_client.rs:102
- crates/cdk/src/wallet/mod.rs:424
d9cb15c to
c267f2b
Compare
Collaborator
Author
|
@cdk-bot review |
c267f2b to
76e7f15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@cdk-bot
Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
ADDED
REMOVED
FIXED
Checklist
just quick-checkbefore committingcrates/cdk-ffi)