Skip to content

Fix auth wallet fetch#2200

Merged
thesimplekid merged 4 commits into
cashubtc:mainfrom
thesimplekid:fix_auth_wallet_fetch
Jul 11, 2026
Merged

Fix auth wallet fetch#2200
thesimplekid merged 4 commits into
cashubtc:mainfrom
thesimplekid:fix_auth_wallet_fetch

Conversation

@thesimplekid

Copy link
Copy Markdown
Collaborator

Description


@cdk-bot

Notes to the reviewers


Suggested CHANGELOG Updates

CHANGED

ADDED

REMOVED

FIXED


Checklist

  • I followed the code style guidelines
  • I ran just quick-check before committing
  • If the Wallet API was modified (added/removed/changed), I have reflected those changes in the FFI bindings (crates/cdk-ffi)

@thesimplekid thesimplekid requested review from asmogo and crodas July 4, 2026 13:11
@github-project-automation github-project-automation Bot moved this to Backlog in CDK Jul 4, 2026
@codecov

codecov Bot commented Jul 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 44.65409% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.56%. Comparing base (5e8683f) to head (76e7f15).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/cdk-common/src/auth/oidc.rs 19.11% 55 Missing ⚠️
...rates/cdk/src/wallet/mint_connector/http_client.rs 0.00% 54 Missing ⚠️
crates/cdk/src/wallet/wallet_repository.rs 28.30% 38 Missing ⚠️
crates/cdk/src/wallet/mod.rs 86.66% 12 Missing ⚠️
crates/cdk/src/wallet/mint_connector/mod.rs 16.66% 10 Missing ⚠️
crates/cdk-http-client/src/transport/mod.rs 0.00% 6 Missing ⚠️
crates/cdk-http-client/src/response.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2200      +/-   ##
==========================================
- Coverage   73.75%   73.56%   -0.19%     
==========================================
  Files         359      360       +1     
  Lines       81144    81432     +288     
==========================================
+ Hits        59851    59909      +58     
- Misses      21293    21523     +230     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

crodas
crodas previously approved these changes Jul 4, 2026
@thesimplekid

Copy link
Copy Markdown
Collaborator Author

@cdk-bot review

@cdk-bot cdk-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified findings approved for disclosure:

  • New required Transport methods break downstream implementors (medium) - External crates implementing the public cdk-http-client Transport trait will fail to compile after upgrading unless they add the two new required methods.
    Unanchored locations included in summary:
    • crates/cdk-http-client/src/transport/mod.rs:45
  • New wallet auth/OIDC APIs are not reflected in cdk-ffi (low) - Foreign-language users of cdk-ffi cannot access or configure the new wallet authentication/OIDC API added by the PR, leaving FFI bindings out of sync with the Rust wallet API.
    Additional locations included in summary:
    • crates/cdk/src/wallet/builder.rs:134

Comment thread crates/cdk-http-client/src/transport/mod.rs
Comment thread crates/cdk/src/wallet/mod.rs
@thesimplekid thesimplekid force-pushed the fix_auth_wallet_fetch branch 3 times, most recently from 1ed3520 to d9cb15c Compare July 6, 2026 22:24
@thesimplekid

Copy link
Copy Markdown
Collaborator Author

@cdk-bot review

@cdk-bot cdk-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified findings approved for disclosure:

  • Existing custom transports can silently lose OIDC support (low) - Wallets using BaseHttpClient/HttpClient with an existing custom Transport can compile unchanged but lose OIDC functionality at runtime unless they add the new raw GET and form POST methods.
    Additional locations included in summary:
    • crates/cdk-http-client/src/transport/mod.rs:72
    • crates/cdk/src/wallet/mint_connector/http_client.rs:102
    • crates/cdk/src/wallet/mod.rs:424

Comment thread crates/cdk-http-client/src/transport/mod.rs
@thesimplekid thesimplekid force-pushed the fix_auth_wallet_fetch branch from d9cb15c to c267f2b Compare July 10, 2026 21:51
@thesimplekid

Copy link
Copy Markdown
Collaborator Author

@cdk-bot review

@thesimplekid thesimplekid force-pushed the fix_auth_wallet_fetch branch from c267f2b to 76e7f15 Compare July 10, 2026 21:58
@thesimplekid thesimplekid merged commit 76e7f15 into cashubtc:main Jul 11, 2026
49 of 51 checks passed
@thesimplekid thesimplekid deleted the fix_auth_wallet_fetch branch July 11, 2026 00:59
@github-project-automation github-project-automation Bot moved this from Backlog to Done in CDK Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants